Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict kwarg type in code generated by @non_differentiable macro #657

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

oxinabox
Copy link
Member

Fixes all the method ambiguities reported in ChainRules CI for julia 1.10

julia> filter(Test.detect_ambiguities(ChainRules, ChainRulesCore)) do t
   (t[1].name in [:rrule, Symbol("rrule##kw")])
end
Tuple{Method, Method}[]

closes JuliaDiff/ChainRules.jl#777

@oxinabox
Copy link
Member Author

oxinabox commented Jan 29, 2024

Yay for first time in ages IntegrationTest / ChainRules.jl (pull_request) Successful in 24m

Copy link
Contributor

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if any reviewer works for you. I'm pleasantly surprised this works all the way back to 1.6.

@oxinabox
Copy link
Member Author

LGTM if any reviewer works for you.

BlueStyle basically says at least 1 person with merge rights needs to be involved in the PR. So if that author has merge rights, the reviewer doesn't have to (and visa versa)

TY.

@oxinabox oxinabox merged commit d2b4b94 into main Jan 30, 2024
19 of 26 checks passed
@oxinabox oxinabox deleted the ox/fix_ci branch January 30, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Method ambiguities causing test failures in Julia 1.10+
2 participants