Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the docs over from ChainRules #115

Merged
merged 26 commits into from
Jan 22, 2020
Merged

Move the docs over from ChainRules #115

merged 26 commits into from
Jan 22, 2020

Conversation

oxinabox
Copy link
Member

There are no docstrings in ChainRules.jl, its just the rules.
Most often when we need to change the docs it is because of changes in ChainRulesCore

They need to automatically build in response to docstrings changing in this package.

ararslan and others added 22 commits January 22, 2020 18:37
* Add Documentation setup with Documenter

This adds no actual documentation, only the infrastructure needed to
set up and deploy documentation.

* Remove testing on 0.7, add 1.1

In the REQUIRE file, the package declares itself to be compatible only
with Julia 1.0 or higher, but 0.7 was still listed in CI. This removes
0.7 and adds 1.1.

It also updates the coverage setup.

* Add a Project.toml file

These are indispensible for local development, and will soon be required
anyway (for some definition of "soon").

* Add missing dependency on ForwardDiff to REQUIRE
This is mostly copying what's in comments in the code into actual doc
files along with the existing docstrings. I've also added a couple of
basic docstrings.
…o remove dev notes until we can restructure them into an advanced tips section
…ChainRulesCore (#93)

* =Remove uses of add and mul from tests because they have been removed from ChainRulesCore

* remove ref to Cassette.
Slightly improve talk of ChainRulesCore

* Update getting_started.md

* Update Project.toml
* PR preview docs

* add link to remind to clean up this code once less evil way is possible

* Update docs/make.jl

* fix typo

* .

* .

* fix docs badge links

* remove debug println

* =highlight readme
* start writing intro

* First full draft

* Update docs/src/index.md

Co-Authored-By: Matt Brzezinski <matt.brzezinski@invenia.ca>

* Update docs/src/index.md

Co-Authored-By: Matt Brzezinski <matt.brzezinski@invenia.ca>

* Update docs/src/index.md

Co-Authored-By: Matt Brzezinski <matt.brzezinski@invenia.ca>

* Apply suggestions from code review

Co-Authored-By: Matt Brzezinski <matt.brzezinski@invenia.ca>

* add FAQ

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Kristoffer Carlsson <kristoffer.carlsson@chalmers.se>

* Update docs/src/index.md

Co-Authored-By: Kristoffer Carlsson <kristoffer.carlsson@chalmers.se>

* Make terminology blocks render. Also style the TOC to match

* move explaintikn of returning value to FAQ

* Reformat docs homepage

* Make sidebar blue

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Fredrik Bagge Carlson <baggepinnen@gmail.com>

* show all ENV during docs building

* Update docs/src/index.md

* Update docs/src/assets/chainrules.css

* Update docs/src/index.md

Co-Authored-By: Seth Axen <seth.axen@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Mateusz Baran <mateuszbaran89@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Glenn Moynihan <glennmoy@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Glenn Moynihan <glennmoy@gmail.com>

* inherit font for admonition title:before

* fix CSS tabs

* Update docs/src/index.md

Co-Authored-By: Seth Axen <seth.axen@gmail.com>

* reorder

* Update docs/src/index.md

Co-Authored-By: Seth Axen <seth.axen@gmail.com>

* Apply suggestions from code review

Co-Authored-By: Seth Axen <seth.axen@gmail.com>
Co-Authored-By: Mateusz Baran <mateuszbaran89@gmail.com>

* fix ffrule repetition

* improve

* add about gradient wrt kwargs

* explain what differentials are

* improve

* wip

* fix citation

Co-Authored-By: Seth Axen <seth.axen@gmail.com>

* Update docs/src/assets/chainrules.css

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* use latex for overbar

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Update docs/src/index.md

Co-Authored-By: simeonschaub <simeondavidschaub99@gmail.com>

* Work on defination of pushforward and pullback

* fixmath

* brackets

* Hide comment

* Describe things a few more times

* add more on dotted and barred forms

* fix note

* not more
* Add Logo

* Add Logo to readme

* fix max size of logo in readme

* fix max size of logo in readme

* fix max size of logo in readme

* fix width in readme
* Add difference between `Zero` and `DoesNotExist` to FAQ

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

Co-authored-by: Nick Robinson <npr251@gmail.com>
* Doc updates for ChainRulesCore 0.5

* Apply suggestions from code review

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update index.md

* Apply suggestions from code review

Co-Authored-By: willtebbutt <wt0881@my.bristol.ac.uk>
Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs/src/index.md

Co-authored-by: Nick Robinson <npr251@gmail.com>
Co-authored-by: willtebbutt <wt0881@my.bristol.ac.uk>
* Remove TODO sections

* Move info about chainrules vs chainrulescore to FAQ
* Break up giant single page of docs

* Update docs/src/writing_good_rules.md

Co-Authored-By: Nick Robinson <npr251@gmail.com>

* Update docs make.jl

Co-authored-by: Nick Robinson <npr251@gmail.com>
* Remove `store!`, `accumulate`, `accumulate!`

* Remove `test_accumulate` functions
docs/make.jl Outdated Show resolved Hide resolved
oxinabox and others added 2 commits January 22, 2020 19:07
Co-Authored-By: Nick Robinson <npr251@gmail.com>
@oxinabox
Copy link
Member Author

Preview Docs: http://www.juliadiff.org/ChainRulesCore.jl/preview-PR115/
(Demonstrating that deploy does indeed still work, so I setup the docs deployment right)

@mattBrzezinski mattBrzezinski self-assigned this Jan 22, 2020
@oxinabox
Copy link
Member Author

All the titles still stay ChainRules, but I am OK with that.
That is the project name.

@oxinabox
Copy link
Member Author

The edit on github button 404's but that is ok because: it is point at master branch which doesn't have these files yet.
https://github.com/JuliaDiff/ChainRulesCore.jl/blob/master/docs/src/index.md

@oxinabox
Copy link
Member Author

the [source] links in the API page seem to work

@nickrobinson251
Copy link
Contributor

Update URL in docs badge on Readme and Index page?

@oxinabox
Copy link
Member Author

Updated Readme.
One in Index is correct. ChainRules.jl is for AD implementors.

Intro pragraph could use update to refer to both packages, but that is not for this PR.

docs/make.jl Show resolved Hide resolved
docs/src/FAQ.md Outdated Show resolved Hide resolved
docs/src/FAQ.md Outdated Show resolved Hide resolved
docs/src/FAQ.md Show resolved Hide resolved
- `ΔΩ` is thus a seed for the pullback.
- `∂Ω` is thus the output of a pushforward.


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

docs/src/assets/make_logo.jl Outdated Show resolved Hide resolved
That pullback function is used like:
`∂self, ∂args... = pullback(Δy)`


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

docs/src/index.md Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
Co-Authored-By: Matt.jl <matt.brzezinski@invenia.ca>
@oxinabox oxinabox merged commit b0b8dbf into master Jan 22, 2020
@nickrobinson251 nickrobinson251 deleted the ox/movedoctsD2 branch January 22, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants