allow AbstractVector input for gradients #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubin
force-pushed
the
ml/abstractvector
branch
from
58f9370
to
73866b5
Compare
|
Updated to |
|
If you feel like it, you could loosen the |
|
Thanks! This is all I need for JuMP, and don't want to create any more merge conflicts than necessary. |
mlubin
added a commit
that referenced
this pull request
Feb 10, 2016
allow AbstractVector input for gradients
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't mean to create unnecessary merge conflicts for #102 (so I didn't add tests), but in JuMP we need to pass around subarrays instead of proper Arrays. I don't see why ForwardDiff should insist on the type of the vector inputs so long as it's indexable.