LB Julia to 1.7, upgrade to ROCm 4.2 #187

jpsamaroo · 2022-01-14T16:47:04Z

Todo:

Add rocRAND_jll
~~Add rocBLAS_jll or~~ upgrade CI to 4.2
Add ld.lld from LLVM_jll
Fix remaining test failures from overlay table changes
Bump minor version

jpsamaroo · 2022-01-14T17:09:21Z

BLAS/RNG failures will probably be solvable by shipping rocRAND_jll (JuliaPackaging/Yggdrasil#4250) and rocBLAS_jll (JuliaPackaging/Yggdrasil#4255) or by updating the CI container to a newer ROCm.

vchuravy · 2022-01-14T17:10:43Z

Next step would be to use methods overlays for device functionality?

jpsamaroo · 2022-01-14T17:14:03Z

Yeah! Do we want that in this PR, or separately?

vchuravy · 2022-01-14T17:23:14Z

Seperatly is fine

luraess · 2022-01-19T23:17:19Z

@jpsamaroo, testing current branch on Vega20 test system:

ROCm 4.2 and JULIA_AMDGPU_DISABLE_ARTIFACTS="1" (not working)

Currently Loaded Modules:
  1) hip-rocclr/4.2.0   3) hsa-rocr-dev/4.2.0   5) llvm-amdgpu/4.2.0   7) rocminfo/4.2.0
  2) hip/4.2.0          4) hsakmt-roct/4.2.0    6) rocm-cmake/4.2.0    8) roctracer-dev-api/4.2.0

export JULIA_AMDGPU_DISABLE_ARTIFACTS="1"

cat ~/.julia/scratchspaces/44cfe95a-1eb2-52ea-b672-e2afdf69b78f/7f20b809462a0fa3410fc3b1300634bb397dc933/build.log
[ Info: Found useable ld.lld at /apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/llvm-amdgpu-4.2.0-rsmtqpi3nz4w2vj5qnvrghl5uyip5iy4/bin/ld.lld
ERROR: LoadError: UndefVarError: find_rocr_library not defined
Stacktrace:
 [1] main()
   @ Main ~/.julia/packages/AMDGPU/UeOHS/deps/build.jl:308
 [2] top-level scope
   @ ~/.julia/packages/AMDGPU/UeOHS/deps/build.jl:348
 [3] include(fname::String)
   @ Base.MainInclude ./client.jl:451
 [4] top-level scope
   @ none:5
in expression starting at /users/lraess/.julia/packages/AMDGPU/UeOHS/deps/build.jl:348
paths = ["/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/llvm-amdgpu-4.2.0-rsmtqpi3nz4w2vj5qnvrghl5uyip5iy4/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hsakmt-roct-4.2.0-unjqrtxlcm4jwdownrhk22j7ryabxzht/lib64", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hsa-rocr-dev-4.2.0-vpyq6owlqwaudbbmb5pvz24b46kg33ff/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hip-4.2.0-vdszeznelp2o4kvqlxgejqau7opvntdi/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hip-rocclr-4.2.0-cgv5qqque36vc6v7pfdplfzfjtz2ti42/lib"]
Could not find library 'rocblas'.
Could not find library 'rocsparse'.
Could not find library 'rocalution'.
Could not find library 'rocfft'.
Could not find library 'MIOpen'.

ROCm 4.3.1 and JULIA_AMDGPU_DISABLE_ARTIFACTS="0" (working)

Currently Loaded Modules:
  1) rocm/4.3.1         4) hsa-rocr-dev/4.3.1   7) rocm-cmake/4.3.1         10) rocprofiler-dev/4.3.1
  2) hip-rocclr/4.3.1   5) hsakmt-roct/4.3.1    8) rocminfo/4.3.1           11) rocm-smi-lib/4.3.1
  3) hip/4.3.1          6) llvm-amdgpu/4.3.1    9) roctracer-dev-api/4.3.1

cat ~/.julia/scratchspaces/44cfe95a-1eb2-52ea-b672-e2afdf69b78f/7f20b809462a0fa3410fc3b1300634bb397dc933/build.log
[ Info: Found useable ld.lld at /apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/llvm-amdgpu-4.3.1-hc5o4e3ffd6uxgm3wwmjf3mzndgwf6sn/bin/ld.lld
paths = ["/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/rocm-smi-lib-4.3.1-66tbwocpjv2fikyuzy2qhlayt4kldx3a/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/rocprofiler-dev-4.3.1-fj54ljtmkegh3jl3ljc47rtspc7kvgcj/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/llvm-amdgpu-4.3.1-hc5o4e3ffd6uxgm3wwmjf3mzndgwf6sn/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hsakmt-roct-4.3.1-54ceqakpcllprna3eoowm4rc7l3ggxm5/lib64", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hsa-rocr-dev-4.3.1-rpmxpbqcx7frbgvaz47bqngp7dnubtpn/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hip-4.3.1-izzfehtmyzlv2akxeoul4axzpyuqhpyx/lib", "/apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/hip-rocclr-4.3.1-fags7ipoy4dwmlivvosynscxthzomgyj/lib"]
Could not find library 'rocblas'.
Could not find library 'rocsparse'.
Could not find library 'rocalution'.
Could not find library 'rocfft'.
Could not find library 'MIOpen'.

juliap -O3 --check-bounds=no memcopy3D_amdgpu.jl
T_eff=730.4036020001471 GB/s

luraess · 2022-02-02T10:11:33Z

@jpsamaroo - Reporting about tests of jps/julia-1.7 branch on Satori (Vega 20 (gfx906)) and Ault (Vega 20 (gfx906)) systems using the amd_bench.jl test script.

Observations:

Power operation ^ failing in kernel:

Float power kernel fails for single and double precision arrays

ERROR stack

ERROR: LoadError: InvalidIRError: compiling kernel memcopy_triad_pow_float!(ROCDeviceMatrix{Float32, 1}, ROCDeviceMatrix{Float32, 1}, ROCDeviceMatrix{Float32, 1}, Float32, Float32) resulted in invalid LLVM IR
Reason: unsupported dynamic function invocation (call to string(a::Union{Char, SubString{String}, String}...) in Base at strings/substring.jl:208)
Stacktrace:
 [1] throw_exp_domainerror
   @ ./math.jl:37
 [2] ^
   @ ./math.jl:916
 [3] memcopy_triad_pow_float!
   @ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:30
Stacktrace:
  [1] check_ir(job::GPUCompiler.CompilerJob{GPUCompiler.GCNCompilerTarget, AMDGPU.ROCCompilerParams, GPUCompiler.FunctionSpec{typeof(memcopy_triad_pow_float!), Tuple{ROCDeviceMatrix{Float32, 1}, ROCDeviceMatrix{Float32, 1}, ROCDeviceMatrix{Float32, 1}, Float32, Float32}}}, args::LLVM.Module)
    @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/validation.jl:111
  [2] macro expansion
    @ ~/.julia/packages/GPUCompiler/fG3xK/src/driver.jl:319 [inlined]
  [3] macro expansion
    @ ~/.julia/packages/TimerOutputs/5tW2E/src/TimerOutput.jl:252 [inlined]
  [4] macro expansion
    @ ~/.julia/packages/GPUCompiler/fG3xK/src/driver.jl:317 [inlined]
  [5] emit_asm(job::GPUCompiler.CompilerJob, ir::LLVM.Module; strip::Bool, validate::Bool, format::LLVM.API.LLVMCodeGenFileType)
    @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/utils.jl:62
  [6] rocfunction_compile(job::GPUCompiler.CompilerJob)
    @ AMDGPU ~/.julia/packages/AMDGPU/tHocd/src/execution.jl:366
  [7] cached_compilation(cache::Dict{UInt64, Any}, job::GPUCompiler.CompilerJob, compiler::typeof(AMDGPU.rocfunction_compile), linker::typeof(AMDGPU.rocfunction_link))
    @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/cache.jl:89
  [8] rocfunction(f::Function, tt::Type; name::Nothing, device::AMDGPU.RuntimeDevice{HSAAgent}, global_hooks::NamedTuple{(), Tuple{}}, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
    @ AMDGPU ~/.julia/packages/AMDGPU/tHocd/src/execution.jl:354
  [9] rocfunction
    @ ~/.julia/packages/AMDGPU/tHocd/src/execution.jl:345 [inlined]
 [10] macro expansion
    @ ~/.julia/packages/AMDGPU/tHocd/src/execution.jl:233 [inlined]
 [11] macro expansion
    @ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:69 [inlined]
 [12] var"##core#631"(threads#576::Tuple{Int64, Int64}, grid#577::Tuple{Int64, Int64}, A#578::ROCMatrix{Float32}, B#579::ROCMatrix{Float32}, C#580::ROCMatrix{Float32}, s#581::Float32, pow_float#582::Float32)
    @ Main ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:483
 [13] var"##sample#632"(::Tuple{Tuple{Int64, Int64}, Tuple{Int64, Int64}, ROCMatrix{Float32}, ROCMatrix{Float32}, ROCMatrix{Float32}, Float32, Float32}, __params::BenchmarkTools.Parameters)
    @ Main ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:489
 [14] _run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; verbose::Bool, pad::String, kwargs::Base.Pairs{Symbol, Integer, NTuple{4, Symbol}, NamedTuple{(:samples, :evals, :gctrial, :gcsample), Tuple{Int64, Int64, Bool, Bool}}})
    @ BenchmarkTools ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:99
 [15] #invokelatest#2
    @ ./essentials.jl:718 [inlined]
 [16] #run_result#45
    @ ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:34 [inlined]
 [17] run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; progressid::Nothing, nleaves::Float64, ndone::Float64, kwargs::Base.Pairs{Symbol, Integer, NTuple{5, Symbol}, NamedTuple{(:verbose, :samples, :evals, :gctrial, :gcsample), Tuple{Bool, Int64, Int64, Bool, Bool}}})

Int power kernel: fails for double precision arrays only

ERROR stack

ERROR: LoadError: LLVM error: Cannot select: 0x460d770: f64 = fpow 0x4dc1b10, 0x460db18, math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ]
 0x4dc1b10: f64,ch = CopyFromReg 0x4c37f28, Register:f64 %25, math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ]
   0x460d290: f64 = Register %25
 0x460db18: f64 = fadd 0x460d840, 0x460cfb8, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
   0x460d840: f64 = LDEXP 0x460d020, Constant:i32<32>, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
     0x460d020: f64 = sint_to_fp 0x2b7ea88, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
       0x2b7ea88: i32 = extract_vector_elt 0x460da48, Constant:i32<1>, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
         0x460da48: v2i32 = bitcast 0x32981a8, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
           0x32981a8: i64,ch = CopyFromReg 0x4c37f28, Register:i64 %28, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
             0x4dc1f88: i64 = Register %28
         0x3297d30: i32 = Constant<1>
     0x2b7ee30: i32 = Constant<32>
   0x460cfb8: f64 = uint_to_fp 0x3298960, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
     0x3298960: i32 = extract_vector_elt 0x460da48, Constant:i32<0>, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
       0x460da48: v2i32 = bitcast 0x32981a8, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
         0x32981a8: i64,ch = CopyFromReg 0x4c37f28, Register:i64 %28, float.jl:146 @[ math.jl:928 @[ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:23 ] ]
           0x4dc1f88: i64 = Register %28
       0x2b7f170: i32 = Constant<0>
In function: _Z33julia_memcopy_triad_pow_int__537314ROCDeviceArrayI7Float64Li2ELi1EES_IS0_Li2ELi1EES_IS0_Li2ELi1EES0_5Int64
Stacktrace:
 [1] handle_error(reason::Cstring)
   @ LLVM ~/.julia/packages/LLVM/vQ98J/src/core/context.jl:105
 [2] LLVMTargetMachineEmitToMemoryBuffer
   @ ~/.julia/packages/LLVM/vQ98J/lib/12/libLLVM_h.jl:965 [inlined]
 [3] emit(tm::LLVM.TargetMachine, mod::LLVM.Module, filetype::LLVM.API.LLVMCodeGenFileType)
   @ LLVM ~/.julia/packages/LLVM/vQ98J/src/targetmachine.jl:45
 [4] mcgen(job::GPUCompiler.CompilerJob, mod::LLVM.Module, format::LLVM.API.LLVMCodeGenFileType)
   @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/mcgen.jl:74
 [5] macro expansion
   @ ~/.julia/packages/TimerOutputs/5tW2E/src/TimerOutput.jl:252 [inlined]
 [6] macro expansion
   @ ~/.julia/packages/GPUCompiler/fG3xK/src/driver.jl:331 [inlined]
 [7] macro expansion
   @ ~/.julia/packages/TimerOutputs/5tW2E/src/TimerOutput.jl:252 [inlined]
 [8] macro expansion
   @ ~/.julia/packages/GPUCompiler/fG3xK/src/driver.jl:328 [inlined]
 [9] emit_asm(job::GPUCompiler.CompilerJob, ir::LLVM.Module; strip::Bool, validate::Bool, format::LLVM.API.LLVMCodeGenFileType)
   @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/utils.jl:62
[10] rocfunction_compile(job::GPUCompiler.CompilerJob)
   @ AMDGPU ~/.julia/packages/AMDGPU/ZIg6T/src/execution.jl:326
[11] cached_compilation(cache::Dict{UInt64, Any}, job::GPUCompiler.CompilerJob, compiler::typeof(AMDGPU.rocfunction_compile), linker::typeof(AMDGPU.rocfunction_link))
   @ GPUCompiler ~/.julia/packages/GPUCompiler/fG3xK/src/cache.jl:89
[12] rocfunction(f::Function, tt::Type; name::Nothing, device::AMDGPU.RuntimeDevice{HSAAgent}, global_hooks::NamedTuple{(), Tuple{}}, kwargs::Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}})
   @ AMDGPU ~/.julia/packages/AMDGPU/ZIg6T/src/execution.jl:314
[13] rocfunction
   @ ~/.julia/packages/AMDGPU/ZIg6T/src/execution.jl:305 [inlined]
[14] macro expansion
   @ ~/.julia/packages/AMDGPU/ZIg6T/src/execution.jl:198 [inlined]
[15] macro expansion
   @ /scratch/lraess/JuliaGPUPerf/amd_bench.jl:65 [inlined]
[16] var"##core#337"(threads#282::Tuple{Int64, Int64}, grid#283::Tuple{Int64, Int64}, A#284::ROCMatrix{Float64}, B#285::ROCMatrix{Float64}, C#286::ROCMatrix{Float64}, s#287::Float64, pow_int#288::Int64)
   @ Main ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:483
[17] var"##sample#338"(::Tuple{Tuple{Int64, Int64}, Tuple{Int64, Int64}, ROCMatrix{Float64}, ROCMatrix{Float64}, ROCMatrix{Float64}, Float64, Int64}, __params::BenchmarkTools.Parameters)
   @ Main ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:489
[18] _run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; verbose::Bool, pad::String, kwargs::Base.Pairs{Symbol, Integer, NTuple{4, Symbol}, NamedTuple{(:samples, :evals, :gctrial, :gcsample), Tuple{Int64, Int64, Bool, Bool}}})
   @ BenchmarkTools ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:99
[19] #invokelatest#2
   @ ./essentials.jl:718 [inlined]
[20] #run_result#45
   @ ~/.julia/packages/BenchmarkTools/SnZV6/src/execution.jl:34 [inlined]
[21] run(b::BenchmarkTools.Benchmark, p::BenchmarkTools.Parameters; progressid::Nothing, nleaves::Float64, ndone::Float64, kwargs::Base.Pairs{Symbol, Integer, NTuple{5, Symbol}, NamedTuple{(:verbose, :samples, :evals, :gctrial, :gcsample), Tuple{Bool, Int64, Int64, Bool, Bool}}})

Using local ROCm installs in both cases with export JULIA_AMDGPU_DISABLE_ARTIFACTS=1. However, no artifacts seem to be used upon unsetting JULIA_AMDGPU_DISABLE_ARTIFACTS
Same GPUs, same Julia version (1.7.0), but AMDGPU.verisoninfo() pretty different on both systems

Satori:

julia> AMDGPU.versioninfo()
HSA Runtime (ready)
- Version: 1.1.0
- Initialized: true
ld.lld (ready)
- Path: /opt/rocm/llvm/bin/ld.lld
HIP Runtime (ready)
ROCm-Device-Libs (ready)
- Downloaded: true
rocBLAS (ready)
rocFFT (ready)
rocRAND (ready)
rocSPARSE (ready)
rocALUTION (ready)
MIOpen (ready)
HSA Agents (2):
- GPU: Vega 20 (gfx906)
- CPU: AMD EPYC 7642 48-Core Processor

Ault:

julia> AMDGPU.versioninfo()
HSA Runtime (ready)
- Version: 1.1.0
- Initialized: true
ld.lld (ready)
- Path: /apps/ault/spack/opt/spack/linux-centos8-zen/gcc-8.4.1/llvm-amdgpu-4.2.0-rsmtqpi3nz4w2vj5qnvrghl5uyip5iy4/bin/ld.lld
HIP Runtime (ready)
ROCm-Device-Libs (ready)
- Downloaded: false
rocBLAS (MISSING)
rocFFT (MISSING)
rocRAND (ready)
rocSPARSE (MISSING)
rocALUTION (MISSING)
MIOpen (MISSING)
HSA Agents (2):
- CPU: AMD EPYC 7742 64-Core Processor
- GPU: Vega 20 WKS GL-XE [Radeon Pro VII] (gfx906)

Moelf · 2022-02-07T14:15:38Z

I still get

┌ Warning: ld.lld was not found, compilation functionality will be unavailable.
│ Please run Pkg.build("AMDGPU") and reload AMDGPU.
│ Reason: ld.lld executable not found
└ @ AMDGPU ~/Documents/github/dotFiles/julia/.julia/dev/AMDGPU/src/AMDGPU.jl:207
┌ Warning: ROCm-Device-Libs were not found, device intrinsics will be unavailable.
│ Please run Pkg.build("AMDGPU") and reload AMDGPU.
│ Reason: unknown
└ @ AMDGPU ~/Documents/github/dotFiles/julia/.julia/dev/AMDGPU/src/AMDGPU.jl:226
┌ Warning: rocRAND failed to load, RNG functionality will be unavailable.
│ Please run Pkg.build("AMDGPU") and reload AMDGPU.
│ Reason: false
└ @ AMDGPU ~/Documents/github/dotFiles/julia/.julia/dev/AMDGPU/src/AMDGPU.jl:235
┌ Error: Exception while generating log record in module Main at /home/akako/Documents/github/dotFiles/julia/.julia/dev/AMDGPU/test/runtests.jl:26
│   exception =
│    UndefRefError: access to undefined reference

is there special driver requirement? I'm not using AMDPRO on Linux

jpsamaroo · 2022-02-07T14:31:45Z

Using local ROCm installs in both cases with export JULIA_AMDGPU_DISABLE_ARTIFACTS=1. However, no artifacts seem to be used upon unsetting JULIA_AMDGPU_DISABLE_ARTIFACTS

You need to do ] build AMDGPU again after changing this variable, since it's only acted upon in the build step.

The power kernel failures are related to us not using method overlay tables like CUDA.jl (intentionally so, because on Julia 1.6 we would break CUDA by using them). Since we're lower-bounding Julia to 1.7, and I've already implemented this locally, I'll push those changes to this PR for testing.

jpsamaroo · 2022-02-07T14:32:04Z

@Moelf can you please post AMDGPU.versioninfo()?

jpsamaroo · 2022-02-07T14:46:21Z

@vchuravy method table overlays added!

Moelf · 2022-02-07T14:50:08Z

julia> AMDGPU.versioninfo()
HSA Runtime (ready)
- Version: 1.1.0
- Initialized: true
ld.lld (MISSING)
HIP Runtime (ready)
ROCm-Device-Libs (MISSING)
rocBLAS (MISSING)
rocFFT (MISSING)
rocRAND (MISSING)
rocSPARSE (MISSING)
rocALUTION (MISSING)
MIOpen (MISSING)
HSA Agents (1):
- CPU: AMD Ryzen 9 3900X 12-Core Processor

We can run without it for many things, and since it often blocks usage of certain cards due to questionable behavior in its library initializer, it is worth not requiring that HIP be available. Fix hipStream_t type in rocBLAS wrapper Add rocSOLVER stubs

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>

jpsamaroo added upstream build labels Jan 14, 2022

jpsamaroo linked an issue Jan 14, 2022 that may be closed by this pull request

Julia 1.7.0 breaks #184

Closed

jpsamaroo requested a review from vchuravy January 14, 2022 16:52

jpsamaroo mentioned this pull request Jan 14, 2022

Problems on 4750U mobile APU #142

Closed

jpsamaroo mentioned this pull request Jan 28, 2022

Julia 1.7.0 breaks #184

Closed

jpsamaroo added 4 commits January 28, 2022 08:46

LB Julia to 1.7, upgrade to ROCm 4.2

bba3f04

Update CI to 1.7

b18ae5f

Remove use of Base.unsafe_length

2bf5bd6

Add rocRAND_jll support

89c70e5

jpsamaroo force-pushed the jps/julia-1.7 branch from cdbdc65 to 91c7e37 Compare January 28, 2022 14:47

This was referenced Jan 28, 2022

Search for device libs relative to LD_LIBRARY_PATH #185

Closed

Add rocm_smi_lib JuliaPackaging/Yggdrasil#4346

Merged

jpsamaroo linked an issue Feb 7, 2022 that may be closed by this pull request

Add method overrides #135

Closed

jpsamaroo added 5 commits February 7, 2022 09:11

Search for device libs relative to LD_LIBRARY_PATH

607a5df

Search [HIP_]DEVICE_LIB_PATH for device libs

78bc27f

CI: Add job with artifacts disabled

ce94add

Remove <1.7 support code

738245c

Make HIP dependency optional

8aa55ea

We can run without it for many things, and since it often blocks usage of certain cards due to questionable behavior in its library initializer, it is worth not requiring that HIP be available. Fix hipStream_t type in rocBLAS wrapper Add rocSOLVER stubs

jpsamaroo force-pushed the jps/julia-1.7 branch 11 times, most recently from 2bb4390 to 79ec593 Compare February 15, 2022 02:18

jpsamaroo and others added 12 commits February 14, 2022 21:29

tests: Don't force ROCArray external lib tests

67a1c94

build: Fix non-artifact HSA search

ec307be

CI: Use Julia 1.8 for no-artifact job

f7d9bbc

build: Improve library detection

a00a20c

init: Ensure core and HIP load when requested

0180050

sync: Test hip_configured statically

0800b54

Co-authored-by: Valentin Churavy <vchuravy@users.noreply.github.com>

build: Check devlibs path vars before default path

ab17d24

init: Load deps vars before sync

8341b4b

build: Search /opt/rocm/lib

15096c7

build: Improve library detection v2

00956a7

rocblas: Use absolute path

577f663

Bump to 0.3.0

c22fd01

jpsamaroo mentioned this pull request Feb 15, 2022

'disable-symbolication' build error #58

Open

jpsamaroo linked an issue Feb 15, 2022 that may be closed by this pull request

Document math intrinsics usage #17

Closed

jpsamaroo mentioned this pull request Feb 15, 2022

Document math intrinsics usage #17

Closed

jpsamaroo linked an issue Feb 15, 2022 that may be closed by this pull request

Embed/wrap lld linker #27

Closed

jpsamaroo force-pushed the jps/julia-1.7 branch from 79ec593 to c22fd01 Compare February 15, 2022 05:00

jpsamaroo merged commit 7e79f2f into master Feb 15, 2022

jpsamaroo deleted the jps/julia-1.7 branch February 15, 2022 05:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LB Julia to 1.7, upgrade to ROCm 4.2 #187

LB Julia to 1.7, upgrade to ROCm 4.2 #187

jpsamaroo commented Jan 14, 2022 •

edited

Loading

jpsamaroo commented Jan 14, 2022 •

edited

Loading

vchuravy commented Jan 14, 2022

jpsamaroo commented Jan 14, 2022

vchuravy commented Jan 14, 2022

luraess commented Jan 19, 2022 •

edited

Loading

luraess commented Feb 2, 2022 •

edited

Loading

Moelf commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

Moelf commented Feb 7, 2022 •

edited

Loading

LB Julia to 1.7, upgrade to ROCm 4.2 #187

LB Julia to 1.7, upgrade to ROCm 4.2 #187

Conversation

jpsamaroo commented Jan 14, 2022 • edited Loading

jpsamaroo commented Jan 14, 2022 • edited Loading

vchuravy commented Jan 14, 2022

jpsamaroo commented Jan 14, 2022

vchuravy commented Jan 14, 2022

luraess commented Jan 19, 2022 • edited Loading

luraess commented Feb 2, 2022 • edited Loading

Moelf commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

jpsamaroo commented Feb 7, 2022

Moelf commented Feb 7, 2022 • edited Loading

jpsamaroo commented Jan 14, 2022 •

edited

Loading

jpsamaroo commented Jan 14, 2022 •

edited

Loading

luraess commented Jan 19, 2022 •

edited

Loading

luraess commented Feb 2, 2022 •

edited

Loading

Moelf commented Feb 7, 2022 •

edited

Loading