-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rocm_smi_lib #4346
Add rocm_smi_lib #4346
Conversation
`rocm_smi_lib` provides a library that reads virtual files in the Linux file system in order to report GPU performance parameters. Both the library and the standard Python script that provides a CLI for the library are included.
I felt the need to include the python files because:
|
And yes, long term we will probably just interface into the |
cc: @jpsamaroo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file must be called build_tarballs.jl
That was embarrassing :D Should be fixed now. |
Can build for more platforms? Or it's relevant only for x86-64 Linux? |
AMD supports ROCm only on x86-64 Linux. It can probably built on any linux (it is a trivial C library that reads some virtual files), but those virtual files would never exist on another linux. |
R/rocm_smi_lib/build_tarballs.jl
Outdated
script = raw""" | ||
cd ${WORKSPACE}/srcdir/rocm_smi_lib-rocm-*/ | ||
mkdir build && cd build | ||
cmake -DCMAKE_INSTALL_PREFIX=${prefix} -DCMAKE_PREFIX_PATH=${prefix} .. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the toolchain file https://docs.binarybuilder.org/stable/build_tips/#CMake-builds
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, noted! I just copied this from rocminfo_jll
. I will have to look into what these differences mean, as I do not have experience with cmake.
@Krastanov if you want to update this for ROCm 4.2.0, we can pull this JLL into JuliaGPU/AMDGPU.jl#187. |
@jpsamaroo , I will do so by the end of the week. |
Admittedly it is a single character diff, but I would like to check that it actually works on the hardware I have. |
@jpsamaroo , here is the 4.2.0 #4350 |
* Add rocm_smi_lib `rocm_smi_lib` provides a library that reads virtual files in the Linux file system in order to report GPU performance parameters. Both the library and the standard Python script that provides a CLI for the library are included. * Fix filename typo * Use -DCMAKE_TOOLCHAIN_FILE
rocm_smi_lib
provides a library that reads virtual filesin the Linux file system in order to report GPU performance
parameters.
Both the library and the standard Python script that provides
a CLI for the library are included.
On a system with a functional AMD GPU and a Python 3
interpreter it can be tested with: