Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate exit/trap with noreturn & inaccessiblememonly #359

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

vchuravy
Copy link
Member

This should help Enzyme to not assume that this assembly has
any effects it needs to handle.

@vchuravy vchuravy force-pushed the vc/callsite_annotation_for_exit branch from b0af98a to dd1a88d Compare October 19, 2022 18:32
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 86.71% // Head: 86.78% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (5121bd0) compared to base (a61466c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
+ Coverage   86.71%   86.78%   +0.06%     
==========================================
  Files          24       24              
  Lines        2801     2808       +7     
==========================================
+ Hits         2429     2437       +8     
+ Misses        372      371       -1     
Impacted Files Coverage Δ
src/irgen.jl 95.28% <100.00%> (+0.02%) ⬆️
src/ptx.jl 92.79% <100.00%> (+0.03%) ⬆️
src/utils.jl 94.44% <100.00%> (+0.69%) ⬆️
src/debug.jl 94.44% <0.00%> (+2.77%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@maleadt maleadt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpsamaroo
Copy link
Member

These attributes are probably incompatible with AMDGPU's exception handling infrastructure, which does a variety of things like accessing a shared hostcall buffer, accessing locks in local (shared) memory, and soon many more things as make enhancements. We should probably add an interface function to check if the target's exception handling functions can be given these attributes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants