Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo "Annotate exception handling with call site effects (#359)" #389

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Feb 6, 2023

Redo the non-PTX related changes from #359 that got reverted in #388.

@vchuravy
Copy link
Member Author

vchuravy commented Feb 6, 2023

Will run Oceananigans testuite over this alone later this today/this week.

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 86.98% // Head: 87.01% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9544c3b) compared to base (3ad8bcc).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   86.98%   87.01%   +0.02%     
==========================================
  Files          24       24              
  Lines        2835     2841       +6     
==========================================
+ Hits         2466     2472       +6     
  Misses        369      369              
Impacted Files Coverage Δ
src/irgen.jl 95.05% <100.00%> (+0.02%) ⬆️
src/utils.jl 98.03% <100.00%> (+0.16%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vchuravy
Copy link
Member Author

vchuravy commented Feb 7, 2023

@wsmoses some concerns by @jpsamaroo in #359 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant