Fix layout fragment type mismatch #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this issue caused a type mismatch in the matmul_pipelined kernel between the return type of Layout.load (inferred by the compiler) and the element type (hinted by the fragtype function)
|
Rebased, so CI should work now. What about a test for this case? |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 42.31% 42.31%
=======================================
Files 9 9
Lines 423 423
=======================================
Hits 179 179
Misses 244 244
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue causing a type mismatch in the
matmul_pipelinedkernel betweenthe return type of Layout.load (inferred by the compiler) and the element type of the
{a,b}_fragmentarrays (hinted by the fragtype function) that came up when working with non-Float16 input matrices.place of mismatch:
GemmKernels.jl/src/kernel.jl
Line 201 in 322d4ca