Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPU operator #81

Closed
wants to merge 4 commits into from
Closed

FPU operator #81

wants to merge 4 commits into from

Conversation

smnbl
Copy link
Contributor

@smnbl smnbl commented Nov 5, 2021

Fixes #75
Fixes #64

@maleadt
Copy link
Member

maleadt commented Nov 9, 2021

Rebased, so CI should work now.

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Base: 39.90% // Head: 39.46% // Decreases project coverage by -0.44% ⚠️

Coverage data is based on head (9b3e596) compared to base (1c15040).
Patch coverage: 9.67% of modified lines in pull request are covered.

❗ Current head 9b3e596 differs from pull request most recent head a8cf454. Consider uploading reports for the commit a8cf454 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #81      +/-   ##
==========================================
- Coverage   39.90%   39.46%   -0.45%     
==========================================
  Files          10        9       -1     
  Lines         436      451      +15     
==========================================
+ Hits          174      178       +4     
- Misses        262      273      +11     
Impacted Files Coverage Δ
src/operator.jl 3.27% <3.44%> (+0.05%) ⬆️
src/config.jl 76.59% <100.00%> (+0.25%) ⬆️
src/layout.jl 16.07% <100.00%> (+0.61%) ⬆️
src/kernel.jl 100.00% <0.00%> (ø)
src/array.jl
src/tiling.jl 87.50% <0.00%> (+1.50%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thomasfaingnaert
Copy link
Member

Also fixes #64, provided @smnbl adds the necessary tests for that case.

@thomasfaingnaert
Copy link
Member

@smnbl I've reverted #83, so if you rebase against the latest master, your implementation should work again.

@maleadt
Copy link
Member

maleadt commented Jun 5, 2023

Superseded by #101

@maleadt maleadt closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants