Fix UndefVar in (::LLAfromECEF) and document ECEF->LLA conversion convention #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Supercedes #49. |
Before this fix, converting from ECEF to LLA coordinates with points very near to the centre of the ellipsoid and with a small value of z (e.g., (x, y, z) = (4e4, 0, 0) for WGS84) would throw an UndefVarError. With this fix, the same LLA point is returned as is done by GeographicLib. However, in this case multiple solutions are present and this fix also documents the choice made. - Change variable name to avoid UndefVarError - Add test based off GeographicLib values - Add explanation of which of several solutions are chosen in the ECEF->LLA conversion to the README.md file.
anowacki
changed the title
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, converting from ECEF to LLA coordinates with
points very near to the centre of the ellipsoid and with a small
value of z (e.g., (x, y, z) = (4e4, 0, 0) for WGS84) would throw
an UndefVarError. With this fix, the same LLA point is returned
as is done by GeographicLib. However, in this case multiple
solutions are present and this fix also documents the choice made.
ECEF->LLA conversion to the README.md file.