Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UndefVar in (::LLAfromECEF) and document ECEF->LLA conversion convention #51

Merged
merged 1 commit into from
Sep 28, 2019
Merged

Fix UndefVar in (::LLAfromECEF) and document ECEF->LLA conversion convention #51

merged 1 commit into from
Sep 28, 2019

Commits on Sep 27, 2019

  1. Fix UndefVar error and document LLA->ECEF conversion convention 

    Before this fix, converting from ECEF to LLA coordinates with
points very near to the centre of the ellipsoid and with a small
value of z (e.g., (x, y, z) = (4e4, 0, 0) for WGS84) would throw
an UndefVarError.  With this fix, the same LLA point is returned
as is done by GeographicLib.  However, in this case multiple
solutions are present and this fix also documents the choice made.

- Change variable name to avoid UndefVarError
- Add test based off GeographicLib values
- Add explanation of which of several solutions are chosen in the
  ECEF->LLA conversion to the README.md file.
    @anowacki
    anowacki committed Sep 27, 2019
    Configuration menu
    Copy the full SHA
    30294bd View commit details
    Browse the repository at this point in the history