Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for 0.7 #139

Closed
wants to merge 11 commits into from
Closed

Conversation

vdayanand
Copy link
Contributor

@vdayanand vdayanand commented Jul 31, 2018

Working on this

[ Info: Listening on: Sockets.InetAddr{IPv4}(ip"127.0.0.1", 0x1f90)
Error During Test at /Users/vdayanan/.julia/dev/Blink/test/runtests.jl:14
  Test threw exception MethodError(isapprox, (Dict{String,Any}(), 2.302585092994046), 0x0000000000006bdb)
  Expression: #= /Users/vdayanan/.julia/dev/Blink/test/runtests.jl:14 =# @js(w, Math.log(10)) ≈ log(10)
  MethodError: no method matching isapprox(::Dict{String,Any}, ::Float64)
  Closest candidates are:
    isapprox(!Matched::Number, ::Number; atol, rtol, nans) at floatfuncs.jl:259
  Stacktrace:
   [1] eval_test(::Expr, ::Expr, ::LineNumberNode) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/Test/src/Test.jl:226
   [2] top-level scope at none:0
   [3] include at ./boot.jl:317 [inlined]
   [4] include_relative(::Module, ::String) at ./loading.jl:1034
   [5] include(::Module, ::String) at ./sysimg.jl:29
   [6] include(::String) at ./client.jl:393
   [7] top-level scope at none:0
   [8] eval(::Module, ::Any) at ./boot.jl:319
   [9] exec_options(::Base.JLOptions) at ./logging.jl:305
   [10] _start() at ./client.jl:427
ERROR: LoadError: There was an error during testing
in expression starting at /Users/vdayanan/.julia/dev/Blink/test/runtests.jl:14
ERROR: Package Blink errored during testing

More v0.7 deprecation fixes
@pfitzseb
Copy link
Member

Hey, what's the status on this, @vdayanand?

@rdeits
Copy link
Collaborator

rdeits commented Aug 13, 2018

With WebSockets.jl master, HTTP.jl master, Mux with JuliaWeb/Mux.jl#66 , WebIO with JuliaGizmos/WebIO.jl#169 and Blink with this PR, I get all of the WebIO tests and Blink tests passing on Julia v0.7. I think we're in good shape if we can get everything merged and tagged.

@randyzwitch
Copy link
Contributor

Getting all this worked out would be super helpful to me, as I rely on Blink.jl for ECharts.jl.

@pfitzseb
Copy link
Member

Superceded by #143.

@pfitzseb pfitzseb closed this Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants