Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another try at Julia v0.7 support #169

Merged
merged 18 commits into from
Aug 17, 2018
Merged

another try at Julia v0.7 support #169

merged 18 commits into from
Aug 17, 2018

Conversation

rdeits
Copy link
Collaborator

@rdeits rdeits commented Aug 11, 2018

Combines #145 and #157

Fixes #172
Fixes #164
Fixes #128
Fixes #47

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 11, 2018

All the WebIO tests except the blink-tests.jl file pass on v0.7 with this branch, but none of our communication actually works because the websocket support via Mux/WebSockets is still not working.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 13, 2018

Good news! With JuliaWeb/Mux.jl#66 , HTTP.jl master, WebSockets.jl master, and the latest changes from b09b03c we now have working websockets in WebIO on v0.7! The clock demo and "random print button" demo from the readme are both working for me with Mux on v0.7.

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 13, 2018

Blink integration also seems to work with JuliaGizmos/Blink.jl#139

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 17, 2018

More changes may be required in the future, but I think we should go ahead and merge this so we can focus on getting Blink working via JuliaGizmos/Blink.jl#139 and vdayanand/Blink.jl#3

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 17, 2018

Ok, I'm going for it :)

@rdeits rdeits merged commit e65dcd2 into master Aug 17, 2018
@rdeits rdeits deleted the rd/v0.7-redux branch August 17, 2018 16:15
@lewisl
Copy link

lewisl commented Aug 17, 2018

Won't build for me still:

 Error: Error building `WebIO`: 
│ WARNING: Base.Pkg is deprecated, run `using Pkg` instead
│   likely near /Users/lewis/.julia/packages/WebIO/RolaR/deps/build.jl:55
│ WARNING: Base.Pkg is deprecated, run `using Pkg` instead
│   likely near /Users/lewis/.julia/packages/WebIO/RolaR/deps/build.jl:55
│ ┌ Warning: `replace(s::AbstractString, pat, f)` is deprecated, use `replace(s, pat => f)` instead.
│ │   caller = install_ijulia_config() at build.jl:15
│ └ @ Main ~/.julia/packages/WebIO/RolaR/deps/build.jl:15
│ ERROR: LoadError: MethodError: no method matching dir()
│ Closest candidates are:
│   dir(!Matched::String, !Matched::AbstractString...) at /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/Pkg/src/API.jl:454
│ Stacktrace:
│  [1] install_ijulia_config() at /Users/lewis/.julia/packages/WebIO/RolaR/deps/build.jl:17
│  [2] top-level scope at none:0
│  [3] include at ./boot.jl:317 [inlined]
│  [4] include_relative(::Module, ::String) at ./loading.jl:1038
│  [5] include(::Module, ::String) at ./sysimg.jl:29
│  [6] include(::String) at ./client.jl:398
│  [7] top-level scope at none:0
│ in expression starting at /Users/lewis/.julia/packages/WebIO/RolaR/deps/build.jl:55
└ @ Pkg.Operations /Users/osx/buildbot/slave/package_osx64/build/usr/share/julia/stdlib/v0.7/Pkg/src/Operations.jl:1068

Looks like it is the load error for dir()

@rdeits
Copy link
Collaborator Author

rdeits commented Aug 17, 2018

@lewisl you need the master branch of WebIO.jl. pkg> add WebIO#master should do it

@lewisl
Copy link

lewisl commented Aug 17, 2018 via email

@shashi
Copy link
Member

shashi commented Aug 19, 2018 via email

@lewisl
Copy link

lewisl commented Aug 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants