-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
another try at Julia v0.7 support #169
Conversation
All the WebIO tests except the |
Good news! With JuliaWeb/Mux.jl#66 , HTTP.jl master, WebSockets.jl master, and the latest changes from b09b03c we now have working websockets in WebIO on v0.7! The clock demo and "random print button" demo from the readme are both working for me with Mux on v0.7. |
Blink integration also seems to work with JuliaGizmos/Blink.jl#139 |
[PR against rd/v0.7-redux] More fixes for 1.0
More changes may be required in the future, but I think we should go ahead and merge this so we can focus on getting Blink working via JuliaGizmos/Blink.jl#139 and vdayanand/Blink.jl#3 |
Ok, I'm going for it :) |
Won't build for me still:
Looks like it is the load error for dir() |
@lewisl you need the master branch of WebIO.jl. |
I never explicitly requested any particular branch. If I didn’t get master it is because something is wrong with the build process for the package.
From: Robin Deits <notifications@github.com>
Reply-To: "JuliaGizmos/WebIO.jl" <reply@reply.github.com>
Date: Friday, August 17, 2018 at 11:52 AM
To: "JuliaGizmos/WebIO.jl" <WebIO.jl@noreply.github.com>
Cc: Lewis Levin <lewis@neilson-levin.org>, Mention <mention@noreply.github.com>
Subject: Re: [JuliaGizmos/WebIO.jl] another try at Julia v0.7 support (#169)
@lewisl<https://github.com/lewisl> you need WebIO.jl master
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#169 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABGLLQ9xM-R_y59M_w0V4Pb5jXzC3J-aks5uRxDagaJpZM4V5HzW>.
|
Thanks. Master was older branch; thought it was released. Master built and compiled.
From: Shashi Gowda <notifications@github.com>
Reply-To: "JuliaGizmos/WebIO.jl" <reply@reply.github.com>
Date: Saturday, August 18, 2018 at 6:10 PM
To: "JuliaGizmos/WebIO.jl" <WebIO.jl@noreply.github.com>
Cc: Lewis Levin <lewis@neilson-levin.org>, Mention <mention@noreply.github.com>
Subject: Re: [JuliaGizmos/WebIO.jl] another try at Julia v0.7 support (#169)
@lewisl This version was not released yet. So you got the old released
version.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#169 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABGLLQWBNKjDpe1aJYJxWD8_3Yw7j_DLks5uSLrngaJpZM4V5HzW>.
|
Combines #145 and #157
Fixes #172
Fixes #164
Fixes #128
Fixes #47