Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "FixedPointNumbers" to "0.8" #399

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2020

This pull request changes the compat entry for the FixedPointNumbers package from 0.6, 0.7 to 0.6, 0.7, 0.8.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #399 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
- Coverage   78.04%   77.80%   -0.25%     
==========================================
  Files          11       11              
  Lines         870      892      +22     
==========================================
+ Hits          679      694      +15     
- Misses        191      198       +7     
Impacted Files Coverage Δ
src/utilities.jl 86.04% <0.00%> (-9.08%) ⬇️
src/parse.jl 94.20% <0.00%> (-2.82%) ⬇️
src/colormaps.jl 95.74% <0.00%> (-0.89%) ⬇️
src/display.jl 98.80% <0.00%> (ø) ⬆️
src/conversions.jl 96.68% <0.00%> (+0.06%) ⬆️
src/differences.jl 29.93% <0.00%> (+0.90%) ⬆️
src/algorithms.jl 61.76% <0.00%> (+1.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1047da...48aeeb9. Read the comment docs.

@kimikage
Copy link
Collaborator

kimikage commented Feb 3, 2020

Perhaps we can merge this, but it might be a good idea to update ColorTypes first. The updating still takes some time.
cf. PR #403

@kimikage kimikage closed this Mar 13, 2020
@kimikage kimikage deleted the compathelper/new_version/2020-02-03-15-04-43-119-581062323 branch March 13, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant