Move promotion rules and some typealiases to ColorTypes.jl v0.10 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
kimikage
force-pushed
the
colortypes_migration
branch
from
5d50164 to
6933286
Compare
kimikage
force-pushed
the
colortypes_migration
branch
from
6933286 to
9bc065c
Compare
kimikage
commented
Mar 3, 2020
timholy
approved these changes
Mar 4, 2020
|
TODO:
It is undecided whether to eliminate the unnecessary conversion methods that are not directly related to this PR. |
timholy
reviewed
Mar 12, 2020
kimikage
force-pushed
the
colortypes_migration
branch
from
9bc065c to
4ef39c6
Compare
kimikage
force-pushed
the
colortypes_migration
branch
from
4ef39c6 to
37997e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
==========================================
+ Coverage 81.95% 82.46% +0.51%
==========================================
Files 11 10 -1
Lines 892 867 -25
==========================================
- Hits 731 715 -16
+ Misses 161 152 -9
Continue to review full report at Codecov.
|
kimikage
force-pushed
the
colortypes_migration
branch
from
37997e0 to
50ed0fb
Compare
Since gray-->rgb conversions were supported and some rgb-->rgb conversions were fixed in ColorTypes.jl, this commit delegates the conversions to ColorType.jl.
kimikage
force-pushed
the
colortypes_migration
branch
from
50ed0fb to
911cfc7
Compare
|
Thank you for the recent reviews, @timholy |
|
Thanks for doing all the heavy lifting, @kimikage! You can just feel the quality shining through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently undergoing a major renovation of ColorTypes.jl. So, this PR is a preview.Since gray-->rgb conversions were supported and some rgb-->rgb conversions were fixed in ColorTypes.jl v0.10, this PR delegates the conversions to ColorType.jl.