Add charts for colordiff to docs and Use docstrings for metrics
#409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 tasks
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 80.58% 80.96% +0.38%
==========================================
Files 11 11
Lines 896 893 -3
==========================================
+ Hits 722 723 +1
+ Misses 174 170 -4 Continue to review full report at Codecov.
|
This was referenced Mar 4, 2020
|
The changes of the constructors in this PR do not substantially break the functionality. Corrections and improvements of the docs are always welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update the docs for color differences (cf. #398 (comment)).
I changed the example for
colordiff, i.e. removed the strangeparse.I also add a doctest for the difference between an
HSVcolor and anHSLcolor. It may help check the PR #407.The PR #407 is ready for merging, but there may be room for improvement on thefma/muladd(cf. #407 (comment)). So, it is another reasonable option to merge this PR first.(Edit: Either is fine now.)PR #407 was merged.