Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example images of simulation of color deficiency #413

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

kimikage
Copy link
Collaborator

@kimikage kimikage commented Mar 8, 2020

@kimikage
Copy link
Collaborator Author

kimikage commented Mar 8, 2020

The sample image included in this PR is the tricky version with reduced colors and sizes. The original version is as follows (CC0).
beads_1920x1080

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 8, 2020

I like the colors 😍

and it's a fantastic image for color2gray algorithms benchmarking, may I add this to TestImages?

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #413 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files          11       11           
  Lines         883      883           
=======================================
  Hits          723      723           
  Misses        160      160

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d01498...4e88d41. Read the comment docs.

@kimikage
Copy link
Collaborator Author

kimikage commented Mar 8, 2020

may I add this to TestImages?

Sure. It is released under the Creative Commons CC0 license. 😄

@kimikage
Copy link
Collaborator Author

I forgot to erase unnecessary code, so I removed it.:sweat_smile:

Since this changes the docs only, I will merge this within a few days if there is no objection.

@timholy
Copy link
Member

timholy commented Mar 12, 2020

It seems likely to be useful for many purposes, not just colors but segmentation algorithms, algorithms inferring depth from blur, etc. And it's just plain beautiful. Thanks, @kimikage!

Out of curiosity, why is it an svg? Did you actually generate this image rather that it being a photograph?

@kimikage
Copy link
Collaborator Author

Out of curiosity, why is it an svg? Did you actually generate this image rather that it being a photograph?

This is a 3d computer-generated image, and post-processed to make some glass beads to be in indistinguishable color pairs.

I hated depending on ImageMagick just for these examples, so I decided to use the technique used in the cross-sectional charts (cf. PR #406), i.e. the use of paletted PNGs. However, 256 colors are too few to represent this image.
And here's the thing. 😄

beads_y
beads_g
beads_r

We shouldn't really use the dithering because of the different color spaces from normal vision. Therefore, I adjusted the hues so that they did not deviate significantly.

@kimikage kimikage merged commit 41444d8 into JuliaGraphics:master Mar 12, 2020
@kimikage kimikage deleted the deficiency branch March 12, 2020 11:14
@kimikage
Copy link
Collaborator Author

kimikage commented Mar 12, 2020

I made a mistake on the HTML syntax. 😭
I don't know whether the cause is it or the embedded PNG, but the github pages hasn't been updated.

Edit: On my personal github pages, it was accepted (even with syntax errors). I'm going to wait and see.
kimikage.github.io/Colors.jl/dev/advancedfunctions/

occursin("<?xml", line) && continue
if occursin("<svg", line)
line = replace(line, ">"=>
"""width="$width" height="$height" style="display:inline; margin-left:1em; margin-bottom:1em">""")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-"""width="$width"
+""" width="$width"

@kimikage
Copy link
Collaborator Author

Updated! 😄
http://juliagraphics.github.io/Colors.jl/latest/advancedfunctions/
(triggerd by PR #373)

@timholy
Copy link
Member

timholy commented Mar 13, 2020

The new docs just look fantastic.

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 14, 2020

FYI, Documenter 0.24 provides a push_preview keyword for non-fork PRs to directly deploy a preview page for others to review

For example, JuliaImages/juliaimages.github.io#115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants