Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

fix #562, bug in reviving objects when WeakRefs are cleared earlier #569

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

JeffBezanson
Copy link
Contributor

Debugged with @vtjnash . The MWE in the issue works with this, but would be good to get some more testing.

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #569 (dc95f74) into master (52d2f73) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   50.15%   50.27%   +0.11%     
==========================================
  Files          32       32              
  Lines        2540     2544       +4     
==========================================
+ Hits         1274     1279       +5     
+ Misses       1266     1265       -1     
Impacted Files Coverage Δ
src/GLib/gtype.jl 75.63% <100.00%> (+0.41%) ⬆️
src/GLib/gerror.jl 50.00% <0.00%> (+10.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d2f73...b349b20. Read the comment docs.

@timholy
Copy link
Member

timholy commented Mar 12, 2021

Awesome! I've tested it locally and it seems solid. Let's merge this and get a new release out.

@timholy timholy merged commit 394c231 into master Mar 12, 2021
@timholy timholy deleted the jb/fix562 branch March 12, 2021 10:07
@tknopp
Copy link
Collaborator

tknopp commented Mar 12, 2021

yea, so much appreciated

@tknopp
Copy link
Collaborator

tknopp commented Mar 12, 2021

I can confirm that this also fixes a crash within the lab software that we have in my research group. This was the last thing making me hesitate using 1.6 beta. Kudos to @JeffBezanson and @vtjnash. 1.6 will be a fantastic release!

@timholy timholy mentioned this pull request Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants