Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WebP #67

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Support for WebP #67

merged 4 commits into from
Oct 31, 2024

Conversation

stemann
Copy link
Member

@stemann stemann commented Apr 15, 2024

Adds support for WebP. - provided JuliaRegistries/General#104921 is merged.

@stemann stemann force-pushed the feature/webp branch 6 times, most recently from 72e0f23 to effa597 Compare April 23, 2024 17:28
@stemann
Copy link
Member Author

stemann commented Apr 23, 2024

Awaiting merge of #68

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.50%. Comparing base (2a06e0b) to head (da2382d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   94.93%   95.50%   +0.56%     
==========================================
  Files           1        1              
  Lines          79       89      +10     
==========================================
+ Hits           75       85      +10     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stemann stemann marked this pull request as ready for review April 26, 2024 17:02
@asinghvi17
Copy link
Member

@stemann is this PR ready to go from your perspective?

test/runtests.jl Outdated Show resolved Hide resolved
Co-authored-by: Anshul Singhvi <anshulsinghvi@gmail.com>
@stemann
Copy link
Member Author

stemann commented Jul 20, 2024

Yes, ready to go

@asinghvi17
Copy link
Member

Will merge tomorrow (Aug 8) if no objections are forthcoming!

@stemann
Copy link
Member Author

stemann commented Oct 22, 2024

Bump :-)

@t-bltg t-bltg mentioned this pull request Oct 30, 2024
@@ -28,6 +29,7 @@ PNGFiles = "0.3, 0.4"
QOI = "1"
Sixel = "0.1.2"
TiffImages = "0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 0.10"
WebP = "0.1.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WebP = "0.1.2"
WebP = "0.1"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The restriction to >= 0.1.2 was on purpose - there were some bad bugs in 0.1.0 and 0.1.1.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be >=0.1.2 then ? I always forget if the >= is implied or if it pins the version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.2 means >=0.1.2, <0.2.0 which is semantically differnt from >=0.1.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always forget this one, thanks for the correction 😌.

Copy link
Member

@johnnychen94 johnnychen94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stemann it would be great if you'd like to move the WebP package into JuliaIO for broader visibility and consistent maintainence.

@johnnychen94 johnnychen94 merged commit 27f8f6f into JuliaIO:master Oct 31, 2024
18 checks passed
@stemann stemann deleted the feature/webp branch November 4, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants