-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Enabled running tests on pull requests #68
Conversation
stemann
commented
Apr 21, 2024
•
edited
Loading
edited
- CI: Updated test workflow from PkgTemplates generated CI workflow
- Also, added julia-cache and codecov-action actions.
- Fixed (TIFF) tests on Windows
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
===========================================
+ Coverage 69.23% 94.93% +25.70%
===========================================
Files 1 1
Lines 26 79 +53
===========================================
+ Hits 18 75 +57
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. |
Might want to |
634186a
to
9cadc4c
Compare
The TIFF tests on Windows were misbehaving since the same file was opened after having been previously opened with mmap: https://github.com/tlnagy/TiffImages.jl/blob/v0.10.0/src/utils.jl#L139 Example of TIFF tests failing on Windows: https://github.com/JuliaIO/ImageIO.jl/actions/runs/8783191936/job/24098831147?pr=69#step:4:497 |
I guess https://github.com/JuliaIO/ImageIO.jl/actions/runs/8783191936 for #69 ran due to dependabot yielding a on:
pull_request: to the CI/test workflow yaml is definitely needed. |
To fix the invalidations test, I think
version: '1'
|
Also, added julia-cache and codecov-action actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for fixing this.