Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TranscodingStreams dependency #253

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Jul 3, 2024

I'm not sure why TranscodingStreams is a dependency of this package.

Both uses in:

@inline function _unsafe_write(io::S, ref::Ref{T}, nb::Integer) where {T,S<:Union{TranscodingStream,BufferedOutputStream,BufferedInputStream}}
GC.@preserve ref unsafe_write(io, Base.unsafe_convert(Ref{T}, ref)::Ptr, nb)
end

and

filepath(io::TranscodingStreams.TranscodingStream) = filepath(io.stream)

are relying on internal details of TranscodingStreams that may break in the future at any time.

Ref: JuliaLang/julia#49125

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.99%. Comparing base (3eb59e1) to head (bcc6c0b).

Files Patch % Lines
src/codec/vbyte.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   92.96%   92.99%   +0.03%     
==========================================
  Files          25       25              
  Lines        2813     2812       -1     
==========================================
  Hits         2615     2615              
+ Misses        198      197       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nhz2 nhz2 marked this pull request as ready for review July 3, 2024 03:11
Copy link
Member

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good cleanup; @Drvi, do you know if there's a specific use-case where we need the TranscodingStream where we can't just rely on something more abstract/generic?

@nhz2
Copy link
Member Author

nhz2 commented Jul 27, 2024

This seems to be indirectly causing some issues. Ref: JuliaIO/TranscodingStreams.jl#234

@nhz2 nhz2 merged commit cc89c24 into master Jul 30, 2024
11 of 16 checks passed
@nhz2 nhz2 deleted the nz/remove-TranscodingStreams-dependency branch July 30, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants