-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Julia v1.6 explicitly in CI #548
Conversation
Codecov ReportBase: 90.36% // Head: 90.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 25 25
Lines 1796 1796
=======================================
Hits 1623 1623
Misses 173 173 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@@ -12,6 +12,7 @@ jobs: | |||
matrix: | |||
version: | |||
- '1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already uses the latest version with pattern 1.*
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ups.... I thought that 1
stood for the LTS, which is 1.6, isn't it? Should I add 1.6 instead of 1.8? Or simply close this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1
stands for latest 1.x.y
stable release. I don't have strong opinions on whether or not we should test on LTS. I guess it could be good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we require Julia 1.5; I think it makes sense to require 1.6 instead, and thus it is healthy to test it.... I'll change this PR. (Yet, I leave this adjustment to #388, which I am reviewing now.)
Thanks @schillic for spotting this!
No description provided.