Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Julia v1.6 explicitly in CI #548

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Test Julia v1.6 explicitly in CI #548

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1281c22
Test Julia v1.8 in CI
lbenet Oct 11, 2022
b301f48
Test 1.6 (instead of 1.8, which corresponds to `1`)
lbenet Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6'
- '1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This already uses the latest version with pattern 1.*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep: https://github.com/JuliaIntervals/IntervalArithmetic.jl/actions/runs/3228974047/jobs/5285738961#step:3:7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ups.... I thought that 1 stood for the LTS, which is 1.6, isn't it? Should I add 1.6 instead of 1.8? Or simply close this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 stands for latest 1.x.y stable release. I don't have strong opinions on whether or not we should test on LTS. I guess it could be good

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we require Julia 1.5; I think it makes sense to require 1.6 instead, and thus it is healthy to test it.... I'll change this PR. (Yet, I leave this adjustment to #388, which I am reviewing now.)

Thanks @schillic for spotting this!

- 'nightly'
os:
Expand Down