Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: Forging ahead in the 1.x era #651

Closed
ararslan opened this issue Feb 8, 2019 · 8 comments · Fixed by #665
Closed

Compat: Forging ahead in the 1.x era #651

ararslan opened this issue Feb 8, 2019 · 8 comments · Fixed by #665

Comments

@ararslan
Copy link
Member

ararslan commented Feb 8, 2019

Now that Julia versions 0.6 and 0.7 are officially unmaintained, I would propose that we drop support for versions prior to 1.0 and focus on providing features from 1.1 and later to 1.0. That would allow Compat to be simplified tremendously, and may help spur developer interest in contributing, since no one cares (or wants to care) about 0.6 anymore.

@martinholters
Copy link
Member

In preparation of #646 I have created a branch locally with everything pre-0.7 removed to see what remains (and check whether any of it should be deprecated). I can clean that up and push it next week. If we want to go ahead here, we should do that first and then tag 2.0.0 I guess.

@ararslan
Copy link
Member Author

ararslan commented Feb 9, 2019

I also have a local branch with these changes that I can push later today. I was about to push it last night but I hadn't finished updating the README.

ararslan added a commit that referenced this issue Feb 9, 2019
The time has come, as 0.6 is unmaintained.

Fixes #651.
@martinholters
Copy link
Member

Ok, go ahead with yours, then.

@martinholters
Copy link
Member

@lobingera want to comment on your 👎? Do you actually write code where you want to use 1.x features while maintaining compatibility with 0.6?

@lobingera
Copy link

lobingera commented Feb 11, 2019

Let's say, i see some questions/complaints showing up in https://github.com/JuliaGraphics/Cairo.jl context when 0.6 compatibility is not available anymore. I've seen this a few times when we tried to reduce 'old' options. There seems to be a lot of code out there that is not constantly updated to newer julia and Cairo seems always to be entangled for creating graphic output.
I understand the need to keep Compat lean but at the same time this means branching at the packages they use it.

@ararslan
Copy link
Member Author

0.6 will continue to work just fine, you just won't be able to use as many 1.1 features while continuing to support 0.6. That seems like a reasonable tradeoff to me.

@davidanthoff
Copy link
Contributor

I think it would be entirely fine to drop julia 0.6 support going forward for a package like Cairo.jl. That would break nothing on existing julia 0.6 installations, and simplify things a lot going forward.

@oxinabox
Copy link
Contributor

oxinabox commented Apr 1, 2019

I think for 1.x Compat should support from most recent LTS (currently and probably forever 1.0) onwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants