Drop support for Julia versions <1.0 #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And some minor clean-up.
|
The README could use some editing, but I'd like to postpone that to a different PR. This PR just deletes obsolete entries, leaving empty sections and such. Also, the README still mentions |
martinholters
referenced
this pull request
Oct 10, 2019
|
Because this will be quite a conflict magnet but also simplify any future work once merged, I don't want to leave it open for too long. So if anyone wants to review (and I'd certainly welcome that) but needs more time, speak up! (Or if anyone has objections...) Otherwise, I'll probably merge in a few days. |
This was referenced Nov 15, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #651, replaces #652.
This removes anything that was relevant only for Julia older than 1.0. It also deprecates a bunch of bindings that were present in
Compatalso for current Julia (e.g.Compat.Test) and removes old deprecations. Thus, anything working with version 2.x without deprecation warnings should also work with this, but possibly with deprecation warnings.Note: When merging, this should obviously be squashed, but the commit message then should see some love and not just list the individual messages.