Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Julia versions <1.0 #665

Merged
merged 121 commits into from
Oct 13, 2019
Merged

Drop support for Julia versions <1.0 #665

merged 121 commits into from
Oct 13, 2019

Conversation

martinholters
Copy link
Member

Closes #651, replaces #652.

This removes anything that was relevant only for Julia older than 1.0. It also deprecates a bunch of bindings that were present in Compat also for current Julia (e.g. Compat.Test) and removes old deprecations. Thus, anything working with version 2.x without deprecation warnings should also work with this, but possibly with deprecation warnings.

Note: When merging, this should obviously be squashed, but the commit message then should see some love and not just list the individual messages.

Note that this still leaves `import Socket` so `using Compat.Sockets`
will still work, although this should be deprecated in the future.
While at it, simplify the syntax of its test due to relaxed 
compatibility requirements.
And mark it for future deprecation
@martinholters
Copy link
Member Author

The README could use some editing, but I'd like to postpone that to a different PR. This PR just deletes obsolete entries, leaving empty sections and such. Also, the README still mentions REQUIRE etc.

@martinholters
Copy link
Member Author

martinholters commented Oct 10, 2019

Because this will be quite a conflict magnet but also simplify any future work once merged, I don't want to leave it open for too long. So if anyone wants to review (and I'd certainly welcome that) but needs more time, speak up! (Or if anyone has objections...) Otherwise, I'll probably merge in a few days.

@martinholters martinholters merged commit 4fa5519 into master Oct 13, 2019
@martinholters martinholters deleted the mh/require_1.0 branch October 13, 2019 07:20
This was referenced Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compat: Forging ahead in the 1.x era
1 participant