Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding get with CartesianIndex #701

Closed
mtsch opened this issue May 12, 2020 · 4 comments · Fixed by #702
Closed

Adding get with CartesianIndex #701

mtsch opened this issue May 12, 2020 · 4 comments · Fixed by #702

Comments

@mtsch
Copy link
Contributor

mtsch commented May 12, 2020

My package is failing on 1.0 because get(::Array, ::CartesianIndex, default) is undefined. I would love to create a pull request for this, but I'm not sure when this feature was added. I can't find anything about it in Julia's NEWS.md.

@martinholters
Copy link
Member

I think this was added in JuliaLang/julia#30268 which would be v1.1.0-DEV.811.

PR welcome!

@mtsch
Copy link
Contributor Author

mtsch commented May 12, 2020

Thanks! Just for future reference, where do you find the correct version if you know the PR/commit?

@martinholters
Copy link
Member

Let me quote our README:

If you're adding additional compatibility code to this package, the contrib/commit-name.sh script in the base Julia repository is useful for extracting the version number from a git commit SHA. For example, from the git repository of julia, run something like this:

bash $ contrib/commit-name.sh a378b60fe483130d0d30206deb8ba662e93944da
0.5.0-dev+2023

This prints a version number corresponding to the specified commit of the form X.Y.Z-aaa+NNNN, and you can then test whether Julia is at least this version by VERSION >= v"X.Y.Z-aaa+NNNN".

@mtsch
Copy link
Contributor Author

mtsch commented May 14, 2020

Thanks, I completely missed that! Sorry for the dumb question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants