add get method that accepts CartesianIndex (# 30259) #30268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3126
commented
Dec 4, 2018
| @@ -89,6 +89,7 @@ module IteratorsMD | |||
|
|
|||
| # indexing | |||
| getindex(index::CartesianIndex, i::Integer) = index.I[i] | |||
| Base.get(A::AbstractArray, I::CartesianIndex, default) = get(A, I.I, default) | |||
There was a problem hiding this comment.
This is probably not the ideal place for this definition. Not sure, where it should go instead.
There was a problem hiding this comment.
Yeah, I think it's ok. Ideally it'd go near the rest of the get methods, but that won't work due to bootstrapping since they live in abstractarray.jl.
timholy
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #30259