Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get with CartesianIndex. #702

Merged
merged 4 commits into from
May 15, 2020
Merged

Add get with CartesianIndex. #702

merged 4 commits into from
May 15, 2020

Conversation

mtsch
Copy link
Contributor

@mtsch mtsch commented May 13, 2020

Closes #701

Let me know if I should also bump the version and what version to reference in README.

martinholters
martinholters approved these changes May 14, 2020
View reviewed changes
Copy link
Member

@martinholters martinholters left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If you want, you can bump the version in Project.toml to 3.10.0 and add a respective "(since Compat 3.10.0)" in the README and we tag a release immediately after merging.

@mtsch
Copy link
Contributor Author

mtsch commented May 15, 2020

Done.

@martinholters martinholters merged commit 1bb5dc7 into JuliaLang:master May 15, 2020
@martinholters
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinholters martinholters martinholters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding get with CartesianIndex
2 participants
@mtsch @martinholters