Fix diagnostics covering trailing text #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
- Coverage 96.80% 96.56% -0.24%
==========================================
Files 14 14
Lines 4125 4138 +13
==========================================
+ Hits 3993 3996 +3
- Misses 132 142 +10
|
Diagnostics may sometimes cover trailing text which wasn't consumed. For example,
`parseatom(")")` doesn't consume the errant trailing ')', but the
diagnostic refers to this character. In this case, `SourceFile` needs to
cover the location of the diagnostic in addition to any text which is
consumed.
As part of this, mark `sourcetext(::ParseStream)` as deprecated, in
favour of constructing a `SourceFile` to wrap things up more neatly.
Also fix a bug in `highlight()` for empty `SourceFile`s.
c42f
force-pushed
the
caf/fix-trailing-diagnostics
branch
from
6e4e7e2
to
fcdd8cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diagnostics may sometimes cover trailing text which wasn't consumed. For example,
parseatom(")")doesn't consume the errant trailing ')', but the diagnostic refers to this character. In this case,SourceFileneeds to cover the location of the diagnostic in addition to any text which is consumed.As part of this, mark
sourcetext(::ParseStream)as deprecated, in favour of constructing aSourceFileto wrap things up more neatly.Also fix a bug in
highlight()for emptySourceFiles.Fixes #314 and downstream issue JuliaLang/julia#50245