Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix diagnostics covering trailing text #317

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix diagnostics covering trailing text #317

merged 1 commit into from
Jun 26, 2023

Commits on Jun 25, 2023

  1. Fix diagnostics covering trailing text 

    Diagnostics may sometimes cover trailing text which wasn't consumed. For example,
`parseatom(")")` doesn't consume the errant trailing ')', but the
diagnostic refers to this character. In this case, `SourceFile` needs to
cover the location of the diagnostic in addition to any text which is
consumed.

As part of this, mark `sourcetext(::ParseStream)` as deprecated, in
favour of constructing a `SourceFile` to wrap things up more neatly.

Also fix a bug in `highlight()` for empty `SourceFile`s.
    @c42f
    c42f committed Jun 25, 2023
    Configuration menu
    Copy the full SHA
    fcdd8cf View commit details
    Browse the repository at this point in the history