This repository has been archived by the owner on Aug 12, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh oh, the test failures look like they might be problematic. |
Which failures? |
https://api.travis-ci.org/v3/job/386058764/log.txt I think it's due to a (now) incorrect use of |
Ah, yes. Probably better fix this before tagging, or it won't work with 0.7-alpha. |
Fix at JuliaStats/StatsBase.jl#384 |
I think we can leave this PR open and attobot will update it when the tag is moved. Is that correct? |
Repository: JuliaStats/StatsBase.jl Please make sure that:
|
attobot
force-pushed
the
StatsBase/v0.23.0
branch
from
May 31, 2018 12:15
e7182ac
to
33be069
Compare
martinholters
approved these changes
May 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
At last! ;-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repository: JuliaStats/StatsBase.jl
Release: v0.23.0
Travis:
Diff: vs v0.22.0
requires
vs v0.22.0: no changescc: @nalimilan
Please make sure that: