Skip to content
This repository has been archived by the owner on Aug 12, 2022. It is now read-only.

Tag StatsBase.jl v0.23.0 #14940

Merged
merged 1 commit into from
May 31, 2018
Merged

Conversation

attobot
Copy link
Contributor

@attobot attobot commented May 31, 2018

Repository: JuliaStats/StatsBase.jl
Release: v0.23.0
Travis: Travis Build Status
Diff: vs v0.22.0
requires vs v0.22.0: no changes
cc: @nalimilan

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@martinholters
Copy link
Member

Oh oh, the test failures look like they might be problematic.

@nalimilan
Copy link
Member

Which failures?

@martinholters
Copy link
Member

Mean and Variance: Error During Test at /home/travis/build/JuliaStats/StatsBase.jl/test/moments.jl:34
  Test threw exception MethodError(-, (0.57, nothing), 0x0000000000006b2b)
  Expression: v == var(x; corrected=corrected = false)
  MethodError: no method matching -(::Float64, ::Nothing)

https://api.travis-ci.org/v3/job/386058764/log.txt

I think it's due to a (now) incorrect use of coalesce.

@nalimilan
Copy link
Member

Ah, yes. Probably better fix this before tagging, or it won't work with 0.7-alpha.

@martinholters
Copy link
Member

Fix at JuliaStats/StatsBase.jl#384

@martinholters
Copy link
Member

I think we can leave this PR open and attobot will update it when the tag is moved. Is that correct?

@attobot
Copy link
Contributor Author

attobot commented May 31, 2018

Repository: JuliaStats/StatsBase.jl
Release: v0.23.0
Travis: Travis Build Status
Diff: vs v0.22.0
requires vs v0.22.0: no changes
cc: @nalimilan

Please make sure that:

  • CI passes for supported Julia versions (if applicable).
  • Version bounds reflect minimum requirements.

@attobot attobot force-pushed the StatsBase/v0.23.0 branch from e7182ac to 33be069 Compare May 31, 2018 12:15
Copy link
Member

@martinholters martinholters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now.

@nalimilan nalimilan merged commit b1120ec into JuliaLang:metadata-v2 May 31, 2018
@attobot attobot deleted the StatsBase/v0.23.0 branch May 31, 2018 12:47
@nalimilan
Copy link
Member

At last! ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants