Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use something instead of coalesce #384

Merged
merged 1 commit into from
May 31, 2018
Merged

Use something instead of coalesce #384

merged 1 commit into from
May 31, 2018

Conversation

martinholters
Copy link
Contributor

No description provided.

@martinholters martinholters mentioned this pull request May 31, 2018
Merged
@martinholters
Copy link
Contributor Author

OSX failure is unrelated (and should go away with Julia > 0.7.0-DEV.5268).
AV 32bit failure also looks unrelated to me.

nalimilan
nalimilan reviewed May 31, 2018
View reviewed changes
src/base.jl Outdated
@@ -1,5 +1,9 @@
# This file contains code formerly part of Julia. License is MIT: https://julialang.org/license

if !isdefined(Base, :something)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better check for VERSION, which will allow Femtocleaner to remove this block automatically. Or add this directly to Compat, which will be useful anyway.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better check for VERSION, which will allow Femtocleaner to remove this block automatically.

Good point, update incoming.

Or add this directly to Compat, which will be useful anyway.

True. But do we want to wait for that to be included in Compat and the release published?

@codecov
Copy link

codecov bot commented May 31, 2018 •
edited
Loading

Codecov Report

Merging #384 into master will increase coverage by 7.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   80.53%   87.88%   +7.35%     
==========================================
  Files          20       20              
  Lines        2281     2287       +6     
==========================================
+ Hits         1837     2010     +173     
+ Misses        444      277     -167
Impacted Files Coverage Δ
src/base.jl 66.4% <ø> (+66.4%) ⬆️
src/scalarstats.jl 95.83% <0%> (+0.01%) ⬆️
src/weights.jl 90.13% <0%> (+0.04%) ⬆️
src/hist.jl 95.95% <0%> (+1.01%) ⬆️
src/deviation.jl 100% <0%> (+1.88%) ⬆️
src/cov.jl 97.05% <0%> (+2.94%) ⬆️
src/StatsBase.jl 81.81% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8659f37...b19ec13. Read the comment docs.

@nalimilan
Copy link
Member

The 32-bit failure on Julia 0.6.3 is JuliaLang/julia#27345.

@nalimilan nalimilan merged commit c6fd8fe into JuliaStats:master May 31, 2018
@martinholters martinholters deleted the mh/something branch May 31, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalimilan nalimilan nalimilan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinholters @nalimilan