Tag OffsetArrays v0.1.0 (retry)

[alsam]

The new pull request instead failed #5416
The previous one failed due to too old julia allowed version in REQUIRE
ERROR: LoadError: METADATA/OffsetArrays/versions/0.1.0/requires: oldest allowed julia version 0.2.0- too old (>= 0.3.0 needed)
Tagged with v0.1.1 to distinguish from the previous pull attempt.

[tkelman]

0.3- is also too old, and would rather not add a new tag supporting any versions of Julia that you aren't actively testing against. Please enable Travis CI using the new language: julia and test against every release version of Julia that you claim to support.

[alsam]

Thanks @tkelman . I've just added travis.yml to repository with language: julia constructs:

language: julia
os:
    - linux
    - osx
julia:
    - 0.3
    - 0.4
    - nightly

Is it ok?

[tkelman]

Yeah that looks good, be sure to enable it. The minimum Julia version acceptable for new tags is julia 0.3 (the trailing dash refers to prereleases, which means 2014 or earlier for 0.3-).

[alsam]

Sure, thanks.
REQUIRE file has also been fixed with julia 0.3 version and committed.
Should I repeat Pkg.publish() to launch Travis CI again?

[tkelman]

Okay, though we should remove or retroactively adjust the requirement on your 0.1.0 tag. If you go through Pkg.publish I believe that'll get left in place unmodified, but we can adjust that in a new branch.

[tkelman]

I'm also referring to Travis CI on your package repository, not here. You need to enable that at https://travis-ci.org/alsam/OffsetArrays.jl

[alsam]

Thanks!
Any of the decisions either remove or retroactively adjust the requirement 0.1.0 tag is ok for me.
If I got this right for moving further it is not required neither launching Pkg.publish() nor committing the changes to the pull-request/b3121d5f branch from my side. Isn't it?

[tkelman]

If you'd like to keep further commits within this branch that would be cleaner from our side.

[alsam]

I fixed julia version to 0.3 in both 0.1.0 and 0.1.1 branches of the branch pull-request/b3121d5f.
Personally I would tag it with 0.1.0 - sorry for confusion with tagging.

[tkelman]

Can you trigger a build on Travis CI to ensure it actually passes?

[alsam]

Sure, it is triggered on Travis CI
The log is here:
https://travis-ci.org/alsam/OffsetArrays.jl/builds/138707160
Some of the jobs succeeded, the others are not,
Summing up a build was triggered on Travis CI there are several errors reported by Travis CI, the errors will be fixed soon.

[alsam]

Ok, Travis CI build passed, the result is here:
https://travis-ci.org/alsam/OffsetArrays.jl/builds/138719889

[tkelman]

Good. Best to tag the commits with the test changes, so what you get from Pkg.add passes too.

[alsam]

Thanks for recommendation.
Tagged with v0.1.2 and got a proposal to create a pull request for v0.1.2.

INFO: To create a pull-request, open:

  https://github.com/alsam/METADATA.jl/compare/pull-request/ef901d0a

Should I open it or it is possible to merge these requests?

[tkelman]

You can push the same metadata commit into this branch if you're familiar enough with git.

[alsam]

Sure, I've done it.

[tkelman]

this commit doesn't include your test fixes, you'll want JuliaArrays/OffsetArrays.jl@012bf5e or newer

[alsam]

Thanks for noticing it. Can't figure out how it had happened because I tagged after the commit. What shall I do to fix, retag with the same tag? (guess it is impossible). How did you figured out the commit using sha1? I'd like to be able doing it myself for checking. Or rather how to recompute the sha1 that corresponds to the correct state? Pkg.tag does it in my understanding but introducing the new unique tag is not a good idea.

[tkelman]

Make sure you're on the latest master before you run Pkg.tag. You can either delete this tag if you don't want it and replace it with a new one, or just move to yet another with 0.1.3.

[alsam]

Ah, I see. Looks like METADATA was stale. If I got this right it is necessary to do Pkg.update() before tagging, isn't?

[tkelman]

Usually a good idea, yes.

[alsam]

Thank you, I bumped it to 0.1.3. It's the simplest solution as removing tag is too handy.