Tag Tau v0.1.0 #7488
Tag Tau v0.1.0 #7488
Conversation
|
Please squash the commits on merging. This is the first METADADA.jl update I'm making since I got commit rights in Tau.jl, and tried to follow the pattern of the past releases, which resulted in a few hiccups in the process. |
| @@ -0,0 +1 @@ | |||
| julia 0.4 | |||
There was a problem hiding this comment.
do tests pass on 0.4? ref JuliaMath/Tau.jl#12 looks like travis isn't enabled?
There was a problem hiding this comment.
I thought I had tested that in JuliaMath/Tau.jl@378fa9f, but I clearly overlooked the definitions in .travis.yml. I'll test in my fork where I have enabled Travis testing (I need @Aerlinger's intervention to enable Travis in the main repo), and will report back.
There was a problem hiding this comment.
@tkelman confirmed, the tests don't actually pass in 0.4. I'll look into supporting it with Compat later (JuliaMath/Tau.jl#13), but for now I'll change the requires file in this PR and in the repo (I could make a new tag and release 0.1.1, but since the travis.yml definitions in 0.1.0 don't actually test 0.4, I think that'd be overkill.)
There was a problem hiding this comment.
Tightening version requirements requires modifying the existing tags in-place like you just did. Releasing a new tag that's 0.5-only wouldn't change the fact that the 0.1.0 tag (if you hadn't just fixed it) would be installable but non-functional on Julia 0.4.
There was a problem hiding this comment.
I'm assuming you're talking about "tags" as in "version directories in METADATA.jl", not actually git tags in the package's repo, in which case, yeah, I see what you mean. Let me know if I misunderstood, though.
There was a problem hiding this comment.
I'm assuming you're talking about "tags" as in "version directories in METADATA.jl"
Right, published versions in METADATA. Those can be a subset of the git tags in the package repo, some of the latter might go unpublished.
This version restores compatibility with Base, after the MathConst --> Irrational change, and makes the tests pass again.