Increase version of StaticArrays in why tests
#4077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suppose this is safe to merge? |
|
To my knowledge, yes. But I'd rather have an expert approve this before breaking anything with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StaticArrays@1.5.0errors onjulia-1.11and so doesStaticArrays@≤1.5.16(JuliaRegistries/General#86950 (comment))I tried to restrict
StaticArrays@≤1.5.16tojulia-1.10in the General Julia Registry in JuliaRegistries/General#116935, but my PR was reverted in JuliaRegistries/General#117626 due to the Pkg tests failing onjulia-1.11, explicitly demanding to addStaticArrays@1.5.0to test thewhyfunctionality.In order to restrict
StaticArrays@≤1.5.16tojulia-1.10and preventing the Pkg tests from erroring, we would need to adapt theStaticArraysversion added in thewhytests to be higher than1.5.16and below1.6.0, e.g.1.5.20.Would it be possible to adjust this in the Pkg tests so that I can start another PR on the General Julia Registry?