Re-enable strict=true for doc generation (#26993)

* fix the last remaining doc problems * re-enable strict=true for doc build, fix #25895
JuliaLang · May 8, 2018 · 12af2d3 · 12af2d3
1 parent 6a23130
commit 12af2d3
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 4 deletions.
diff --git a/base/abstractarray.jl b/base/abstractarray.jl
@@ -158,6 +158,22 @@ julia> length(1:5)
 julia> length([1, 2, 3, 4])
 4
 
+julia> length([1 2; 3 4])
+4
+```
+"""
+length
+
+"""
+    length(A::AbstractArray)
+
+Return the number of elements in the array, defaults to `prod(size(A))`.
+
+# Examples
+```jldoctest
+julia> length([1, 2, 3, 4])
+4
+
 julia> length([1 2; 3 4])
 4
 ```

diff --git a/base/array.jl b/base/array.jl
@@ -231,6 +231,8 @@ Create a shallow copy of `x`: the outer structure is copied, but not all interna
 For example, copying an array produces a new array with identically-same elements as the
 original.
 """
+copy
+
 copy(a::T) where {T<:Array} = ccall(:jl_array_copy, Ref{T}, (Any,), a)
 
 # reshaping to same # of dimensions

diff --git a/doc/make.jl b/doc/make.jl
@@ -154,7 +154,7 @@ makedocs(
     doctest   = ("doctest-fix" in ARGS) ? (:fix) : ("doctest" in ARGS),
     linkcheck = "linkcheck" in ARGS,
     linkcheck_ignore = ["https://bugs.kde.org/show_bug.cgi?id=136779"], # fails to load from nanosoldier?
-    strict    = false,
+    strict    = true,
     checkdocs = :none,
     format    = "pdf" in ARGS ? :latex : :html,
     sitename  = "The Julia Language",

diff --git a/doc/src/base/arrays.md b/doc/src/base/arrays.md
@@ -157,7 +157,7 @@ Base.invperm
 Base.isperm
 Base.permute!(::Any, ::AbstractVector)
 Base.invpermute!
-Base.reverse
+Base.reverse(::AbstractVector; kwargs...)
 Base.reverseind
 Base.reverse!
 ```

diff --git a/doc/src/base/collections.md b/doc/src/base/collections.md
@@ -127,7 +127,6 @@ Base.last
 Base.step
 Base.collect(::Any)
 Base.collect(::Type, ::Any)
-Base.issubset(::Any, ::Any)
 Base.filter
 Base.filter!
 Base.replace(::Any, ::Pair...)

diff --git a/stdlib/LinearAlgebra/src/transpose.jl b/stdlib/LinearAlgebra/src/transpose.jl
@@ -153,7 +153,7 @@ Eagerly evaluate the lazy matrix transpose/adjoint.
 Note that the transposition is applied recursively to elements.
 
 This operation is intended for linear algebra usage - for general data manipulation see
-[`Base.permutedims`](@ref), which is non-recursive.
+[`permutedims`](@ref Base.permutedims), which is non-recursive.
 
 # Examples
 ```jldoctest