Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make documentation pass with strict = true again. #25895

Closed
KristofferC opened this issue Feb 5, 2018 · 0 comments
Closed

Make documentation pass with strict = true again. #25895

KristofferC opened this issue Feb 5, 2018 · 0 comments
Labels
docsystem The documentation building system

Comments

@KristofferC
Copy link
Sponsor Member

Since #25706 the documentation no longer passes with strict = true.
This is because #25706 promoted some warnings:

 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitRevWalker' in devdocs/libgit2.md
 !! Invalid local link: unresolved path
    '../../devdocs/libgit2/#Base.LibGit2.GitHash' in devdocs/libgit2.md
 ...

to errors

!! No doc found for reference '[`GitRevWalker`](@ref)'. [src/base/collections.md]
 !! No doc found for reference '[`GitHash`](@ref)'. [src/base/collections.md]
...

This seems to be due to referring to e.g. GitRevWalker in the LibGit2 extended method Base.map. I am not really sure why this happens though. One way to "solve" this would be to decouple Base.map and LibGit2.map similar to #24837.

@KristofferC KristofferC added the docsystem The documentation building system label Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docsystem The documentation building system
Projects
None yet
Development

No branches or pull requests

1 participant