Merge pull request #19800 from ararslan/aa/farewell-collections

RFC: Move PriorityQueue and heap functions out of Base

NEWS.md

@@ -78,6 +78,9 @@ This section lists changes that do not have deprecation warnings.
 
   * `quadgk` has been moved from Base into a separate package. ([#19741])
 
+  * The `Collections` module has been removed, and all functions defined therein have been
+    moved to the `DataStructures` package. ([#19800])
+
   * The `RepString` type has been moved to the
     [LegacyStrings.jl package](https://github.com/JuliaArchive/LegacyStrings.jl).
 

base/array.jl

@@ -560,6 +560,24 @@ function append!{T}(a::Array{T,1}, items::AbstractVector)
     return a
 end
 
+append!(a::Vector, iter) = _append!(a, iteratorsize(iter), iter)
+
+function _append!(a, ::HasLength, iter)
+    n = length(a)
+    resize!(a, n+length(iter))
+    @inbounds for (i,item) in zip(n+1:length(a), iter)
+        a[i] = item
+    end
+    a
+end
+
+function _append!(a, ::IteratorSize, iter)
+    for item in iter
+        push!(a, item)
+    end
+    a
+end
+
 """
     prepend!(a::Vector, items) -> collection