RFC: Move PriorityQueue and heap functions out of Base #19800
Conversation
ararslan
force-pushed
the
aa/farewell-collections
branch
from
c4da300
to
d3f11cb
Compare
ararslan
force-pushed
the
aa/farewell-collections
branch
from
d3f11cb
to
c6f07d2
Compare
| for f in (:PriorityQueue, :enqueue!, :dequeue!, :heapify!, :heapify, :heappop!, :heappush!, :isheap, :peek) | ||
| @eval function ($f)(args...; kwargs...) | ||
| error(string($f, args, " has been moved to the package DataStructures.jl.\n", | ||
| "Run Pkg.add(\"DataStructures\") to install DataStructures on Julia v0.6 and later, ", |
There was a problem hiding this comment.
there's nothing 0.6 specific about this?
There was a problem hiding this comment.
Only in that they aren't (/won't be) in Base in 0.6. I just followed the text from QuadGK and Primes.
There was a problem hiding this comment.
will DataStructures use base's copy on 0.5, or define its own equivalent version? I think either would be fine in this case, as long as you aren't overwriting methods or otherwise causing issues or conflicts
There was a problem hiding this comment.
It defines its own version using the code as of 0.6 (with a single slight modification to make it work on 0.4). Should be entirely equivalent to what's in Base in 0.5.
|
Note that the PR title is "WIP" only because the changes have not been incorporated into DataStructures; this is otherwise good to go I think. Once that's done I'll change the title here to "RFC" to reflect its mergeability. |
ararslan
changed the title
This PR is the Base companion to JuliaCollections/DataStructures.jl#238; it removes the entire Collections module and makes all functions currently exported from that module error, in a similar fashion to QuadGK and Primes.
This should not be merged until the DataStructures PR is merged and the package tagged.
edit by tkelman: closes #18497