Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibGit2 should not use a NULL refspec in git_remote_push #21639

Closed
yuyichao opened this issue Apr 29, 2017 · 1 comment
Closed

LibGit2 should not use a NULL refspec in git_remote_push #21639

yuyichao opened this issue Apr 29, 2017 · 1 comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module upstream The issue is with an upstream dependency, e.g. LLVM

Comments

@yuyichao
Copy link
Contributor

yuyichao commented Apr 29, 2017 •
edited
Loading

Apparently this was never allowed since the introduction of this function 3 years ago but is used in libgit2/remote.jl and is now being tested..... This only crashes with a debug build of libgit2 so it's possible that the requirement can be relaxed in libgit2.
@yuyichao yuyichao added bug Indicates an unexpected problem or unintended behavior libgit2 The libgit2 library or the LibGit2 stdlib module labels Apr 29, 2017
@yuyichao yuyichao mentioned this issue Apr 29, 2017
Merged
@yuyichao
Copy link
Contributor Author

Patch submitted upstream libgit2/libgit2#4225 . Meanwhile we shouldn't have much issue since we build libgit2 with assertion off....

yuyichao added a commit that referenced this issue May 1, 2017
@yuyichao
Add libgit2 patch to allow NULL refspec in git_remote_push
c984203 
Ref libgit2/libgit2#4225

Fix #21639
@yuyichao yuyichao mentioned this issue May 1, 2017
Merged
@yuyichao yuyichao added upstream The issue is with an upstream dependency, e.g. LLVM and removed bug Indicates an unexpected problem or unintended behavior labels May 1, 2017
tkelman pushed a commit that referenced this issue May 4, 2017
@yuyichao @tkelman
Add libgit2 patch to allow NULL refspec in git_remote_push
af360eb 
Ref libgit2/libgit2#4225

Fix #21639

(cherry picked from commit c984203)
ref #21665
tkelman pushed a commit that referenced this issue May 4, 2017
@yuyichao @tkelman
Add libgit2 patch to allow NULL refspec in git_remote_push
8b5a2e7 
Ref libgit2/libgit2#4225

Fix #21639

(cherry picked from commit c984203)
ref #21665
This was referenced May 11, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module upstream The issue is with an upstream dependency, e.g. LLVM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuyichao