Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable two libgit2 tests with libgit2 < 0.26.0 #21872

Merged
merged 1 commit into from
May 15, 2017
Merged

Disable two libgit2 tests with libgit2 < 0.26.0 #21872

merged 1 commit into from
May 15, 2017

Conversation

nalimilan
Copy link
Member

@nalimilan nalimilan commented May 14, 2017

Without our patches libgit2-remote-push-NULL and libgit2-gitconfig-symlink,
which are not yet included in an upstream release, these tests fail.
Disable them so that builds using the system libgit2 can pass the tests.

See #21597 (comment), #21639 and #21636.

@nalimilan
Copy link
Member Author

I don't know, but if we ask them to do they would probably accept given that the patch is simple and cannot break existing code. Or to be safe we could check that libgit2 >= 0.26.

@tkelman
Copy link
Contributor

tkelman commented May 14, 2017

I just asked on their slack channel, will see what they say. Looking at the response in libgit2/libgit2#4220 it sounds like they might not want to do an 0.25.2 and instead plan on doing 0.26.0 soon, but if that has API changes it would require more work on our side.

How hard is it to get trivial patches into the fedora libgit2 package?

@ararslan ararslan added libgit2 The libgit2 library or the LibGit2 stdlib module test This change adds or pertains to unit tests labels May 14, 2017
@nalimilan
Copy link
Member Author

I just asked on their slack channel, will see what they say. Looking at the response in libgit2/libgit2#4220 it sounds like they might not want to do an 0.25.2 and instead plan on doing 0.26.0 soon, but if that has API changes it would require more work on our side.

Anyway we'll use 0.26 at some point, won't we? There's no real hurry to enable this test, which wasn't present in 0.5.

How hard is it to get trivial patches into the fedora libgit2 package?

Not really hard, but I'd rather have Julia build with the system libgit2 than depend on custom patches. There are other distribution packages out there, and people may want to use their system libgit2 for some reason.

@tkelman
Copy link
Contributor

tkelman commented May 14, 2017

Fair enough. Let's enable the test for >= v"0.26.0" then, unless I hear back soon about whether there will be an 0.25.2

Without our patches libgit2-remote-push-NULL and libgit2-gitconfig-symlink,
which are not yet included in an upstream release, these tests fail.
Disable them so that builds using the system libgit2 can pass the tests.
@nalimilan
Copy link
Member Author

OK, I've updated the patch. I've also realized that after disabling this test, another test from #21636 failed for the same reasons, so I've added a condition for it too. With this, all tests pass when building the Fedora RPM.

@nalimilan nalimilan changed the title Disable LibGit2.push test with libgit2 <= 0.25.1 Disable two libgit2 tests with libgit2 < 0.26.0 May 14, 2017
@tkelman tkelman merged commit a204bfd into master May 15, 2017
@tkelman tkelman deleted the nl/libgit2 branch May 15, 2017 12:19
tkelman pushed a commit that referenced this pull request May 15, 2017
Without our patches libgit2-remote-push-NULL and libgit2-gitconfig-symlink,
which are not yet included in an upstream release, these tests fail.
Disable them so that builds using the system libgit2 can pass the tests.
(cherry picked from commit a204bfd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libgit2 The libgit2 library or the LibGit2 stdlib module test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants