loading: make precompile the default #26991

vtjnash · 2018-05-05T02:50:25Z

This is nice, because it simplifies the require code. That should also make error handling more understandable and predictable. And the problems resulting from non-precompile-declaring code is used from __precompile__ code simply won't exist anymore.

fix #26282

StefanKarpinski · 2018-05-09T12:22:27Z

Bump?

KristofferC · 2018-05-09T12:59:44Z

There should be a warning that people aren't allowed to write too big numbers in their code.

StefanKarpinski · 2018-05-09T13:03:09Z

Or maybe just fix that issue?

stevengj · 2018-05-10T17:16:54Z

So this makes things less reliable and slower for new users (whose first modules are typically small and frequently reloaded as they develop), while not affecting load times for large packages (which inevitably turn precompilation on when they begin to mature). Great?

But I agree that this simplifies the situation for precompiled modules loading modules lacking a __precompile__ statement.

stevengj · 2018-05-10T17:20:35Z

base/loading.jl

-        throw(PrecompilableError(isprecompilable))
+@noinline function __precompile__(isprecompilable::Bool=false)
+    if isprecompilable
+        depwarn("__precompile__() is now the default", :__precompile__)


This deprecation seems painful: it will require an explicit VERSION check for code that wants to continue to be precompiled in 0.6 without the warning, since __precompile__() lives outside the module (before Compat is loaded).

FWIW, such version checks were the norm when precompilation was introduced. So instead of VERSION >= v"0.4.0-something" && __precompile__() it would be a check against 0.7. Not saying it's an ideal situation, just that it isn't without precedent.

Good point.

I don't see why, in general, changing the default value for something should require changes when the desired value is explicitly chosen by the package developer.

This required every package that didn't use __precompile__(false) to make additional changes for 0.7-rc2, while I think it should have just been limited to those packages that didn't have an explicit __precompile__()/__precompile__(true)/__precompile__(false) statement. Alternatively, automated PRs could have been opened against all packages to change this syntax.

Just my two cents.

JeffBezanson · 2018-05-10T20:03:55Z

I'd be much more comfortable with this if the BigInt issue can be fixed first.

JeffBezanson · 2018-05-22T18:37:28Z

It doesn't feel like this decision needs to block 0.7 alpha. Moving to 1.0.

vtjnash · 2018-07-24T16:41:08Z

Hm, seems like this is trigger an issue with the Pkg tests that has snuck in since I last rebased this. There appears to be a minor misunderstanding in the way that Pkg is attempting to use Base.compilecache, based on the current limitations of that cache. (Briefly, it is checking out a package, but some statements are perhaps misordered, so it's not checking whether the result was successful. This triggers a slight interaction there whereby it can now trigger the precompile code, revealing that the result is of this uncertain consistency in Pkg state.) Until Base is fixed, we perhaps should disable the automated calls to the compilation method if there are any modules currently loaded, as Pkg is currently overriding the logic in Base that would normally do that (and is currently therefore likely wasting time, in this case, doing lots of precompile work that is not useful).

StefanKarpinski · 2018-07-24T18:14:15Z

It seems like you're uniquely positioned to understand and fix that breakage. Let me know if there's any assistance I can provide.

ararslan · 2018-07-26T20:17:30Z

From triage: @JeffBezanson is going to look into addressing the BigInt literal issue then this will be revisited. It's expected to be in 0.7-rc1.

ararslan · 2018-07-28T04:37:28Z

Rebased to fix merge conflicts.

JeffBezanson · 2018-07-30T19:13:20Z

Bump. This is unblocked now. Would be reeeeeally nice to get this in today if it's in 0.7.

ararslan · 2018-07-30T19:20:51Z

I think the outstanding issue is the Pkg thing Jameson mentioned. @vtjnash, do you know what needs to happen to fix that?

fix #26282

ViralBShah · 2018-07-31T12:29:25Z

@vtjnash Is this good to merge?

timholy · 2018-08-01T09:52:20Z

xref #28384

Adapt to JuliaLang/julia#26991.

Fix deprecation warnings

mdashti · 2018-08-15T14:15:54Z

What's the best way to stay compatible with 0.6 in our packages, as having __precompile__(true) is an error in Julia 1.0? A related discussion here: FluxML/MacroTools.jl@18448ba#r30081444

KristofferC · 2018-08-15T14:50:42Z

Conditionally execute it based on VERSION.

tkoolen · 2018-08-15T15:09:29Z

I've used VERSION < v"0.7.0-beta2.199" && __precompile__(). But it's really only 0.7 that complains when you have __precompile__(true), right? (after #28459)

StefanKarpinski · 2018-08-15T15:22:57Z

0.7 is not supposed to complain about that anymore either unless that change didn't get merged.

tkoolen · 2018-08-15T15:28:33Z

Ah yes, I guess it was just the 0.7 release candidates.

JuliaLang/julia#26991

fix #26282

Julia packages are precompilable by default since 2018: <JuliaLang/julia#26991>. See also: `?__precompile__`.

- Remove unnecessary `__precompile__` statement. Julia packages are precompilable by default since 2018: <JuliaLang/julia#26991>. - Update `import` statements. The `import ... as` syntax has been introduced in Julia 1.6. - Update comments.

fix #26282

ararslan added the compiler:precompilation Precompilation of modules label May 5, 2018

vchuravy added the needs news A NEWS entry is required for this change label May 5, 2018

vtjnash added the triage This should be discussed on a triage call label May 9, 2018

stevengj reviewed May 10, 2018

View reviewed changes

vtjnash mentioned this pull request May 18, 2018

precompile: support @big_str parsed integers #27144

Closed

JeffBezanson added this to the 1.0 milestone May 22, 2018

JeffBezanson removed the triage This should be discussed on a triage call label May 22, 2018

vtjnash force-pushed the jn/precompile-default branch from 2586846 to d21962a Compare July 13, 2018 16:55

vtjnash force-pushed the jn/precompile-default branch 2 times, most recently from 4f56ec4 to 72f9e67 Compare July 20, 2018 20:21

vtjnash added triage This should be discussed on a triage call and removed needs news A NEWS entry is required for this change labels Jul 20, 2018

StefanKarpinski modified the milestones: 1.0, 0.7 Jul 26, 2018

StefanKarpinski removed the triage This should be discussed on a triage call label Jul 26, 2018

ararslan mentioned this pull request Jul 26, 2018

Set VERSION to 0.7.0-rc1 #28294

Merged

13 tasks

JeffBezanson mentioned this pull request Jul 26, 2018

fix #15722, support BigInts in precompiled modules and sysimg #28296

Merged

ararslan force-pushed the jn/precompile-default branch from 72f9e67 to c76bf28 Compare July 28, 2018 04:37

loading: make __precompile__ the default

eba6f03

fix #26282

vtjnash force-pushed the jn/precompile-default branch from c76bf28 to eba6f03 Compare July 31, 2018 03:41

vtjnash merged commit 6026374 into master Jul 31, 2018

vtjnash deleted the jn/precompile-default branch July 31, 2018 13:20

fredrikekre mentioned this pull request Jul 31, 2018

Remove __precompile__([true]) calls. JuliaComputing/Deprecations.jl#83

Closed

tpapp mentioned this pull request Aug 1, 2018

Remove __precompile__, as it is now the default. timholy/Revise.jl#119

Merged

tkoolen added a commit to tkoolen/LoopThrottle.jl that referenced this pull request Aug 2, 2018

Precompile default

b5afbb8

Adapt to JuliaLang/julia#26991.

tkoolen mentioned this pull request Aug 2, 2018

Precompile default tkoolen/LoopThrottle.jl#3

Merged

tkoolen added a commit to tkoolen/TypeSortedCollections.jl that referenced this pull request Aug 2, 2018

Precompile default

fea3938

Adapt to JuliaLang/julia#26991.

This was referenced Aug 2, 2018

Precompile default tkoolen/TypeSortedCollections.jl#33

Closed

Precompile fix. osqp/OSQP.jl#24

Merged

cstjean referenced this pull request in FluxML/MacroTools.jl Aug 15, 2018

Merge pull request #87 from pfitzseb/sp/julia-1.0

18448ba

Fix deprecation warnings

epatters added a commit to AlgebraicJulia/Catlab.jl that referenced this pull request Aug 31, 2018

Remove __precompile__(), because it is now the default.

6e84941

JuliaLang/julia#26991

epatters added a commit to epatters/Serd.jl that referenced this pull request Aug 31, 2018

Remove __precompile__(), because it is now the default.

9f68925

JuliaLang/julia#26991

epatters added a commit to epatters/SPARQL.jl that referenced this pull request Aug 31, 2018

Remove __precompile__(), because it is now the default.

f4a1f35

JuliaLang/julia#26991

KristofferC pushed a commit that referenced this pull request Feb 11, 2019

loading: make __precompile__ the default (#26991)

e2a5d2f

fix #26282

Paalon mentioned this pull request Mar 4, 2020

Remove __precompile__(), because it is the default for >= v0.7.0. JuliaStats/ConjugatePriors.jl#40

Merged

ericphanson mentioned this pull request Jun 6, 2020

Add build step jump-dev/BARON.jl#40

Merged

devmotion mentioned this pull request Oct 9, 2021

Some suggestions JuliaMath/InverseFunctions.jl#1

Merged

matteorossini added a commit to Electa-Git/FlexPlan.jl that referenced this pull request Nov 3, 2022

Remove unneeded __precompile__ statement

6cfd839

Julia packages are precompilable by default since 2018: <JuliaLang/julia#26991>. See also: `?__precompile__`.

Keno pushed a commit that referenced this pull request Jun 5, 2024

loading: make __precompile__ the default (#26991)

893ccca

fix #26282

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

loading: make precompile the default #26991

loading: make precompile the default #26991

vtjnash commented May 5, 2018

StefanKarpinski commented May 9, 2018

KristofferC commented May 9, 2018

StefanKarpinski commented May 9, 2018

stevengj commented May 10, 2018 •

edited

Loading

stevengj May 10, 2018

ararslan May 12, 2018

stevengj May 12, 2018

tkoolen Aug 4, 2018

JeffBezanson commented May 10, 2018

JeffBezanson commented May 22, 2018

vtjnash commented Jul 24, 2018

StefanKarpinski commented Jul 24, 2018

ararslan commented Jul 26, 2018

ararslan commented Jul 28, 2018

JeffBezanson commented Jul 30, 2018

ararslan commented Jul 30, 2018

ViralBShah commented Jul 31, 2018

timholy commented Aug 1, 2018

mdashti commented Aug 15, 2018

KristofferC commented Aug 15, 2018

tkoolen commented Aug 15, 2018

StefanKarpinski commented Aug 15, 2018

tkoolen commented Aug 15, 2018

loading: make __precompile__ the default #26991

loading: make __precompile__ the default #26991

Conversation

vtjnash commented May 5, 2018

StefanKarpinski commented May 9, 2018

KristofferC commented May 9, 2018

StefanKarpinski commented May 9, 2018

stevengj commented May 10, 2018 • edited Loading

stevengj May 10, 2018

Choose a reason for hiding this comment

ararslan May 12, 2018

Choose a reason for hiding this comment

stevengj May 12, 2018

Choose a reason for hiding this comment

tkoolen Aug 4, 2018

Choose a reason for hiding this comment

JeffBezanson commented May 10, 2018

JeffBezanson commented May 22, 2018

vtjnash commented Jul 24, 2018

StefanKarpinski commented Jul 24, 2018

ararslan commented Jul 26, 2018

ararslan commented Jul 28, 2018

JeffBezanson commented Jul 30, 2018

ararslan commented Jul 30, 2018

ViralBShah commented Jul 31, 2018

timholy commented Aug 1, 2018

mdashti commented Aug 15, 2018

KristofferC commented Aug 15, 2018

tkoolen commented Aug 15, 2018

StefanKarpinski commented Aug 15, 2018

tkoolen commented Aug 15, 2018

loading: make precompile the default #26991

loading: make precompile the default #26991

stevengj commented May 10, 2018 •

edited

Loading