Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set VERSION to 0.7.0-rc1 #28294

Merged
merged 1 commit into from
Jul 31, 2018
Merged

Set VERSION to 0.7.0-rc1 #28294

merged 1 commit into from
Jul 31, 2018

Conversation

@StefanKarpinski
Copy link
Member

must be lowercase

@ararslan ararslan changed the title Set VERSION to 0.7.0-RC1 Set VERSION to 0.7.0-rc1 Jul 26, 2018
@tknopp
Copy link
Contributor

tknopp commented Jul 26, 2018

What about #13099 ? It solves a real issue, which is a pain to work around in Gtk.jl. Also it seems that PR ist all set.

@JeffBezanson
Copy link
Member

Yes, we could perhaps merge that now, but I would consider it non-breaking so it's not urgent to get it into any particular version.

@tknopp
Copy link
Contributor

tknopp commented Jul 26, 2018

But it fixes a bug that persists since 3 years and leads to segfaults: JuliaGraphics/Gtk.jl#161. So its not like a feature request but a request to solve a bug which makes GUI programming with Gtk much harder than it is for other languages. I have code where the sigatom workaround cited in JuliaGraphics/Gtk.jl#161 does not work and in turn cannot proceed.

@JeffBezanson
Copy link
Member

If everybody is allowed to block the release on a bug of their choosing, there will never be a release. I do want to merge #13099 though. Hopefully we'll be able to merge it by 1.0.x.

@tknopp
Copy link
Contributor

tknopp commented Jul 26, 2018

sorry, I did not want to say that this is blocking the release just bringing to attention that there is a fix for a bug leading to a segfaults. From other segfault reports I had the impression that there is some interest getting these fixed prior to a release. But yes, no urgent need. Gtk.jl will require time for being updated to 1.0 anyway.

@ararslan
Copy link
Member Author

ararslan commented Jul 29, 2018

Looks like @rfourquet added #27944, which isn't on the milestone nor marked for triage. Yea or nay?

@rfourquet
Copy link
Member

Looks like @rfourquet added #27944, which isn't on the milestone nor marked for triage. Yea or nay?

Yes, with a question mark because it was rejected in triage but now Jeff re-opened it. It's a conservative Yea for me, but definitely not crucial (but should be decided before rc1 I think).

@JeffBezanson
Copy link
Member

#27944 deletes functions that were only added in 0.7, so it's low risk and the concern is avoiding adding an API that we might not want to commit to.

#13099 is non-breaking but involves a complete redesign of the task code, so is quite risky. It seems to work well as far as any of us know, but we all know how that goes.

@ararslan
Copy link
Member Author

#28310?

@maleadt
Copy link
Member

maleadt commented Jul 30, 2018

I'd like to add #28291, which is a pretty small bugfix that makes it possible to @profile CUDAnative code. Review & approved, CI is green, so good to go but nonetheless putting it here for consideration.

@JeffBezanson JeffBezanson added this to the 0.7 milestone Jul 30, 2018
@ararslan
Copy link
Member Author

Somehow that checklist seems to keep getting longer... 😉

@StefanKarpinski
Copy link
Member

It just got shorter—we're not doing #28193.

@ararslan
Copy link
Member Author

HERE. WE. GO.

@ararslan ararslan merged commit 15fcc7c into master Jul 31, 2018
@ararslan ararslan deleted the aa/0.7.0-RC1 branch July 31, 2018 20:29
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants