-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set VERSION to 0.7.0-rc1 #28294
Set VERSION to 0.7.0-rc1 #28294
Conversation
must be lowercase |
What about #13099 ? It solves a real issue, which is a pain to work around in Gtk.jl. Also it seems that PR ist all set. |
Yes, we could perhaps merge that now, but I would consider it non-breaking so it's not urgent to get it into any particular version. |
But it fixes a bug that persists since 3 years and leads to segfaults: JuliaGraphics/Gtk.jl#161. So its not like a feature request but a request to solve a bug which makes GUI programming with Gtk much harder than it is for other languages. I have code where the |
If everybody is allowed to block the release on a bug of their choosing, there will never be a release. I do want to merge #13099 though. Hopefully we'll be able to merge it by 1.0.x. |
sorry, I did not want to say that this is blocking the release just bringing to attention that there is a fix for a bug leading to a segfaults. From other segfault reports I had the impression that there is some interest getting these fixed prior to a release. But yes, no urgent need. Gtk.jl will require time for being updated to |
Looks like @rfourquet added #27944, which isn't on the milestone nor marked for triage. Yea or nay? |
Yes, with a question mark because it was rejected in triage but now Jeff re-opened it. It's a conservative Yea for me, but definitely not crucial (but should be decided before rc1 I think). |
#27944 deletes functions that were only added in 0.7, so it's low risk and the concern is avoiding adding an API that we might not want to commit to. #13099 is non-breaking but involves a complete redesign of the task code, so is quite risky. It seems to work well as far as any of us know, but we all know how that goes. |
I'd like to add #28291, which is a pretty small bugfix that makes it possible to |
Somehow that checklist seems to keep getting longer... 😉 |
It just got shorter—we're not doing #28193. |
HERE. WE. GO. |
The following need to be merged first: