fix #15722, support BigInts in precompiled modules and sysimg #28296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
compiler:precompilation
vtjnash
reviewed
Jul 27, 2018
src/dump.c
Outdated
| @@ -921,6 +922,17 @@ static void jl_serialize_value_(jl_serializer_state *s, jl_value_t *v, int as_li | |||
| for (i = 0; i < jl_datatype_nfields(jl_lineinfonode_type); i++) | |||
| jl_serialize_value(s, jl_get_nth_field(v, i)); | |||
| } | |||
| else if (jl_bigint_type && jl_typeis(v, jl_bigint_type)) { | |||
| write_uint8(s->s, TAG_SHORT_GENERAL); | |||
| write_uint8(s->s, ((jl_datatype_t*)jl_bigint_type)->size); | |||
JeffBezanson
force-pushed
the
jb/savebigint
branch
from
73e12d2 to
9adfb9d
Compare
JeffBezanson
force-pushed
the
jb/savebigint
branch
from
9adfb9d to
7c5317b
Compare
ChrisRackauckas
added a commit
to SciML/OrdinaryDiffEq.jl
that referenced
this pull request
Jul 28, 2018
ChrisRackauckas
added a commit
to SciML/StochasticDiffEq.jl
that referenced
this pull request
Jul 28, 2018
ChrisRackauckas
added a commit
to SciML/DiffEqDevTools.jl
that referenced
this pull request
Jul 28, 2018
ChrisRackauckas
added a commit
to SciML/StochasticDiffEq.jl
that referenced
this pull request
Aug 18, 2018
ChrisRackauckas
added a commit
to SciML/DiffEqDevTools.jl
that referenced
this pull request
Aug 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ugly, but I think it's necessary if we're going to do #26991.
The only limitation here is that you can't mutate BigInts from the system image, but I think that's acceptable since we don't expose a mutating API, constants shouldn't be mutated anyway, and we typically have more control over what goes into a system image (as opposed to a precompiled package).