basic support for printing to TTYs from multiple threads #31438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
io
JeffBezanson
force-pushed
the
jb/threadio
branch
from
681d93d to
b9d36ae
Compare
JeffBezanson
force-pushed
the
jb/threadio
branch
2 times, most recently
from
0eb3168 to
d44feb5
Compare
JeffBezanson
changed the title
start adding some synchronization to I/O this yields basic support for printing to TTYs from multiple threads
JeffBezanson
force-pushed
the
jb/threadio
branch
from
d44feb5 to
55f0367
Compare
vtjnash
reviewed
Apr 4, 2019
| check_open(s) | ||
| while true | ||
| uvw = Libc.malloc(_sizeof_uv_write) | ||
| uv_req_set_data(uvw, C_NULL) # in case we get interrupted before arriving at the wait call | ||
| uv_req_set_data(uvw, reqdata) |
There was a problem hiding this comment.
please don't delete comments that say precisely why your change is wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with #31398 and #31437 this allows printing to work from
@threadsloops. Currently, it just has threads poll for I/O instead of blocking during@threads. That will be fixed. It also does not yet make all I/O thread safe, but you can at least print to TTYs.