Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in iterate on Dicts vs 1.1 #31760

Closed
KristofferC opened this issue Apr 18, 2019 · 0 comments
Closed

Regression in iterate on Dicts vs 1.1 #31760

KristofferC opened this issue Apr 18, 2019 · 0 comments
Assignees
Labels
performance Must go faster regression Regression in behavior compared to a previous version

Comments

@KristofferC
Copy link
Member

KristofferC commented Apr 18, 2019

#31452 introduced a regression in calling iterate on dictionaries as reported by the Nanosoldier run at #31727 (comment).

On master:

julia> d = Dict(3 => 3);

julia> @btime iterate($d);
  106.997 ns (2 allocations: 64 bytes)

With #31452 reverted

julia> @btime iterate($d)
  3.400 ns (0 allocations: 0 bytes)

cc @JeffBezanson, @ndinsmore

@KristofferC KristofferC added performance Must go faster regression Regression in behavior compared to a previous version labels Apr 18, 2019
@KristofferC KristofferC added this to the 1.2 milestone Apr 18, 2019
@JeffBezanson JeffBezanson self-assigned this Apr 18, 2019
@KristofferC KristofferC mentioned this issue Apr 20, 2019
58 tasks
KristofferC pushed a commit that referenced this issue Apr 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Must go faster regression Regression in behavior compared to a previous version
Projects
None yet
Development

No branches or pull requests

2 participants