Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 1.2-RC1 #31727

Closed
wants to merge 71 commits into from
Closed

Backports for 1.2-RC1 #31727

wants to merge 71 commits into from

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC commented Apr 15, 2019

Backported PRs:

Non-merged PRs with backport label:

JeffBezanson and others added 10 commits April 15, 2019 14:27
(cherry picked from commit b08f120)
it should only widen a signature, not narrow it, but was using intersect instead of subtype

fix #31406

(cherry picked from commit b4e95cb)
Using a WeakRef meant we might not actually `bind` the result.
If nobody was still holding a reference to put contents into the Condition,
we would simply garbage collect it, and then never need to close it.
Since that does not seem to be the intent,
instead move to just keeping a strong reference
(alternatively, we would have to switch to using `stream_wait`
with ref-counting, but that seems suboptimal for several reasons.).

fix #31507

(cherry picked from commit 29f61cd)
* edit 1.2 release notes

* Run NEWS-update.jl

(cherry picked from commit ccd9574)
(cherry picked from commit 20834c3)
@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Apr 15, 2019
@vchuravy
Copy link
Member

Backported the non-feature part of #31489

@ararslan ararslan added the release Release management and versioning. label Apr 15, 2019
@ararslan ararslan added this to the 1.2 milestone Apr 15, 2019
@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs = ":release-1.0")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@fredrikekre
Copy link
Member

Can drop #31679 in favor of #31749.

@maleadt
Copy link
Member

maleadt commented Apr 18, 2019

Added #31687, merged both commits into one.

JeffBezanson and others added 8 commits April 20, 2019 10:45
- avoid exponential search in `is_derived_type` when parameters are
  used as field types
- avoid inferring `show_default`
- improve a fast path in subtyping

(cherry picked from commit b2b35e9)
(cherry picked from commit c83e312)
when we hit union-splitting, we need to ensure type limits are very aggressive
and preferably also independent of the height of the recursion chain

fix #31572

(cherry picked from commit 32b091b)
(cherry picked from commit d5e365c)
@KristofferC
Copy link
Member Author

KristofferC commented May 20, 2019

Most Pkg regressions fixed. Need fix to #32084 and then we should rerun PkgEval.

@nanosoldier runbenchmarks(ALL, vs=":release-1.1")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

@Keno
Copy link
Member

Keno commented May 20, 2019

Looks pretty good overall. The sparse matmul memory regressions maybe deserve investigation, as do the Union{Missing, BigInt} benchmarks that seem to have gotten a bit slower.

@KristofferC
Copy link
Member Author

BigFloat regressions are #31759.

@Keno
Copy link
Member

Keno commented May 20, 2019

are right, thanks.

staticfloat and others added 2 commits May 22, 2019 08:54
It is possible when marking task objects in the GC for the associated
jl_ptls_t reference to be NULL. To determine whether a task is a root
task, we therefore also have to check if that reference is valid.

(cherry picked from commit 25c33e4)
@KristofferC
Copy link
Member Author

@nanosoldier runbenchmarks(ALL, vs=":release-1.1")

@nanosoldier
Copy link
Collaborator

Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan

timholy and others added 5 commits May 23, 2019 22:06
This restricts the element type of the input vector to be `<:Real` and
only converts in case the promoted type is concrete.

Fixes #32092.

(cherry picked from commit 587cb82)
…s set (#31725)

Also renames `USE_BINARYBUILDER_UNWIND` to `USE_BINARYBUILDER_LIBUNWIND`
for consistency, as well as providing a little bit of dependency logic
to auto-disable `USE_BINARYBUILDER_SUITESPARSE` if `USE_SYSTEM_BLAS` is
set, for example.

(cherry picked from commit 5f808c6)
@KristofferC
Copy link
Member Author

@staticfloat, could you double check my backport for your commit above this comment

@KristofferC
Copy link
Member Author

I think we should rerun PkgEval now @ararslan

@staticfloat
Copy link
Member

could you double check my backport for your commit above this comment

One minor issue, I have directly pushed the fix; it wasn't critical, but it's better this way.

@ararslan
Copy link
Member

Newest PkgEval run regressions:

  • AlgebraicMultigrid
  • Alpine
  • AmplNLWriter
  • ArnoldiMethod
  • BSON
  • BilevelOptimization
  • BlackBoxOptim
  • BoltzmannMachines
  • BrowseTables
  • COSMO
  • Cassette
  • ConicNonlinearBridge
  • Discretizers
  • DistributedArrays
  • DocumentFunction
  • EcologicalNetworks
  • FillArrays
  • HypothesisTests
  • InfoZIP
  • JuMPeR
  • Latexify
  • Libtask
  • MLDataPattern
  • MatrixNetworks
  • Millboard
  • NLPModelsJuMP
  • Nullables
  • OptimizationProblems
  • PkgTemplates
  • Polyhedra
  • PriorityChannels
  • QuantumLattices (ran for 14+ hours, forcibly killed)
  • Rebugger
  • RemoteFiles
  • ResumableFunctions
  • RingBuffers
  • Rotations
  • SpinMonteCarlo
  • StructJuMP
  • SymEngine
  • UnicodePlots

Logs are here: https://gist.github.com/ararslan/fd6edd0d6d3b61babab8cb7fe5b661f0.

@ararslan ararslan removed the needs pkgeval Tests for all registered packages should be run with this change label May 29, 2019
@JeffBezanson
Copy link
Member

Merged and rc1 tagged.

@ararslan ararslan mentioned this pull request Jul 1, 2019
32 tasks
@ararslan ararslan mentioned this pull request Jul 23, 2019
14 tasks
@ararslan ararslan deleted the backports-release-1.2 branch July 26, 2019 13:33
@DilumAluthge DilumAluthge removed the DO NOT MERGE Do not merge this PR! label Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release management and versioning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.