Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #31663, long inference time printing large tree structure #31680

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

JeffBezanson
Copy link
Member

@JeffBezanson JeffBezanson commented Apr 10, 2019

  • avoid exponential search in is_derived_type when parameters are used as field types
  • avoid inferring show_default
  • improve a fast path in subtyping

fixes #31663

Does not do anything for #31572; that seems to be different.

base/show.jl Outdated Show resolved Hide resolved
- avoid exponential search in `is_derived_type` when parameters are
  used as field types
- avoid inferring `show_default`
- improve a fast path in subtyping
@KristofferC KristofferC mentioned this pull request Apr 15, 2019
58 tasks
@JeffBezanson JeffBezanson merged commit b2b35e9 into master Apr 16, 2019
@JeffBezanson JeffBezanson deleted the jb/fix31663 branch April 16, 2019 16:35
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
- avoid exponential search in `is_derived_type` when parameters are
  used as field types
- avoid inferring `show_default`
- improve a fast path in subtyping

(cherry picked from commit b2b35e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:inference Type inference performance Must go faster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia 1.0/1.1 can't handle deep nested structs
3 participants