Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 31252 - remote globals not being updated in some cases #31446

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Fix issue 31252 - remote globals not being updated in some cases #31446

merged 1 commit into from
Apr 20, 2019

Conversation

amitmurthy
Copy link
Contributor

Fixes issue #31252 .

@ViralBShah ViralBShah added the parallelism Parallel or distributed computation label Mar 23, 2019
@amitmurthy amitmurthy requested a review from JeffBezanson March 23, 2019 02:28
@amitmurthy
Copy link
Contributor Author

Bump @JeffBezanson

@ViralBShah
Copy link
Member

Or perhaps even @vtjnash

@amitmurthy
Copy link
Contributor Author

Thanks. Will merge. Closing and reopening to trigger CI.

@amitmurthy amitmurthy closed this Apr 3, 2019
@amitmurthy amitmurthy reopened this Apr 3, 2019
@amitmurthy amitmurthy closed this Apr 10, 2019
@amitmurthy amitmurthy reopened this Apr 10, 2019
@raminammour
Copy link
Contributor

Will this make it to v1.2 ?

@amitmurthy
Copy link
Contributor Author

I'll close and reopen once again to trigger CI. The OSX failure appears to be unrelated (errors in package testing) and I don't understand some of the buildbot errors. As I am not current with the release cycle, would appreciate it if someone takes a look after the test run completes and merges.

@amitmurthy amitmurthy closed this Apr 19, 2019
@amitmurthy amitmurthy reopened this Apr 19, 2019
@amitmurthy
Copy link
Contributor Author

All green other than buildbot/package_win32. Will merge today evening if there are no objections.

@vchuravy vchuravy merged commit 4955696 into master Apr 20, 2019
@vchuravy vchuravy deleted the amitm/31252 branch April 20, 2019 15:38
@vchuravy
Copy link
Member

@amitmurthy should this be backported to 1.0/1.1?

@amitmurthy
Copy link
Contributor Author

Yes. Have added the labels.

@amitmurthy amitmurthy added the bugfix This change fixes an existing bug label Apr 20, 2019
@KristofferC KristofferC mentioned this pull request May 9, 2019
Closed
58 tasks
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
@KristofferC KristofferC mentioned this pull request Dec 3, 2019
Closed
56 tasks
Keno pushed a commit that referenced this pull request Jun 5, 2024
@vchuravy
Merge pull request #31446 from JuliaLang/amitm/31252
a97f361 
Fix issue 31252 - remote globals not being updated in some cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash approved these changes

@JeffBezanson JeffBezanson Awaiting requested review from JeffBezanson

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug parallelism Parallel or distributed computation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@amitmurthy @ViralBShah @raminammour @vchuravy @vtjnash @KristofferC