Automatically disable USE_BINARYBUILDER_xxx when USE_SYSTEM_xxx is set

[staticfloat]

Also renames USE_BINARYBUILDER_UNWIND to USE_BINARYBUILDER_LIBUNWIND
for consistency, as well as providing a little bit of dependency logic
to auto-disable USE_BINARYBUILDER_SUITESPARSE if USE_SYSTEM_BLAS is
set, for example.

[staticfloat]

Requesting review from @vtjnash to ensure that my ?= initializations are equivalent to his previous fix regarding respecting user settings.

[staticfloat]

This is failing Appveyor because we have an incoherent set of makevars set:

USE_SYSTEM_SUITESPARSE = 1
USE_SYSTEM_ARPACK = 1
USE_SYSTEM_BLAS = 1
USE_SYSTEM_LAPACK = 1
USE_SYSTEM_GMP = 1
USE_SYSTEM_MPFR = 1
USE_SYSTEM_PCRE = 1
USE_SYSTEM_LIBUNWIND = 1
override LIBLAPACK = $(LIBBLAS)
override LIBLAPACKNAME = $(LIBBLASNAME)
override DEP_LIBS = libuv utf8proc
USE_BINARYBUILDER_LLVM = 1
USE_BINARYBUILDER_OPENBLAS = 1
USE_BINARYBUILDER_SUITESPARSE = 1

We can't have USE_SYSTEM_xxx and USE_BINARYBUILDER_xxx set at the same time. Which should it be?

[vchuravy]

If I recall the appveyor script correctly it should be USE_BINARYBUILDER, USE_SYSTEM is a lie since we are getting them from elsewhere (and sometimes that is the lastest nightly)

[staticfloat]

USE_SYSTEM is a lie since we are getting them from elsewhere (and sometimes that is the latest nightly)

With the new BB system, I don't think this is necessary anymore. We should be able to build from scratch; we don't need to bootstrap off of the previous build's libraries anymore.

[wavexx]

Would it be possible to set USE_BINARYBUILDER:=0 in Make.user to avoid all pre-compiled binaries without having to set them manually? This seems to be set very late in Make.inc, so there's no way to override that.

When debugging I want to some compiler flags to be set through-out and be sure that either the library comes from the system (which means I also rebuilt them but in a shared location) or is truly rebuild from source.

[staticfloat]

Would it be possible to set USE_BINARYBUILDER:=0 in Make.user to avoid all pre-compiled binaries without having to set them manually?

Yes, absolutely. That's the purpose of Make.user, and the purpose of USE_BINARYBUILDER. Just put the following in your Make.user:

override USE_BINARYBUILDER=0

The override will short-circuit our calculations to try and auto-determine whether USE_BINARYBUILDER should be set on or off.

[wavexx]

On Tue, Apr 16 2019, Elliot Saba wrote: > Would it be possible to set USE_BINARYBUILDER:=0 in Make.user to avoid all pre-compiled binaries without having to set them manually? Yes, absolutely. That's the purpose of `Make.user`, and the purpose of `USE_BINARYBUILDER`. Just put the following in your `Make.user`:

This doesn't really work though (I tried beforehand). I can override individual deps, but not all of them.

[staticfloat]

Here's an example of how to do it, and how to check that it is working. First, let's check that the buildsystem wants to use BinaryBuilder for LLVM:

$ make print-USE_BINARYBUILDER_LLVM
USE_BINARYBUILDER_LLVM=1

Now, let's tell the buildsystem to not use BinaryBuilder; we'll flip the global switch, then check to see what the build system wants to do with LLVM:

$ echo "override USE_BINARYBUILDER=0" >> Make.user
$ make print-USE_BINARYBUILDER_LLVM
USE_BINARYBUILDER_LLVM=0

This was verified with the latest master, which is c9786e6. If it's not working for you, please open a new issue about USE_BINARYBUILDER=0 not being honored on your system, and we'll try to figure out what's not working for you.

[wavexx]

On Tue, Apr 16 2019, Yuri D'Elia wrote: > Yes, absolutely. That's the purpose of `Make.user`, and the purpose of `USE_BINARYBUILDER`. Just put the following in your `Make.user`: This doesn't really work though (I tried beforehand). I can override individual deps, but not all of them.

Ok, scratch that, I forgot to do a full clean inbetween. It would be nicer if overriding wasn't needed though. I guess it's not possible to move the check earlier in Make.inc, before the inclusion of Make.user?

[staticfloat]

I guess it's not possible to move the check earlier in Make.inc, before the inclusion of Make.user?

The timing of Make.user is intentional. The reason it's not working without override is because because I neglected to use ?= for the initial definition of USE_BINARYBUILDER, which I have now included in this PR. Often we don't want to pick up values from environment variables (which ?= will do) but in this case USE_BINARYBUILDER is unique enough that I don't think we need to worry about that (whereas we would need to worry about it for things like CC, CFLAGS, etc..., and so the user must use things like override for those in their Make.user)

[staticfloat]

Does appveyor not use my .appveyor.yml from my branch, instead using the one from master? EDIT: Nevermind, the appveyor page was cached weirdly; I see the new build now.

[vchuravy]

😂

[JeffBezanson]

Bump. What's the status of this? Ready to merge?

[staticfloat]

Needed a rebase and a trim; assuming this passes CI, it's good to merge.

[JeffBezanson]

This is set in .travis.yml; needs to be renamed there.